1820591 - Add herald rule for devtools-reviewers

Status: RESOLVED FIXED

(Conduit :: Administration, task)

Description

[Nicolas Chevobbe [:nchevobbe][PTO - back on October 21]]

Hello,

Could we create a new herald rule for the devtools-reviewers group (https://phabricator.services.mozilla.com/project/profile/153/) that adds it as a blocking reviewer when:

• files under the following path change: devtools/
• files under the following path change: testing/talos/talos/tests/devtools/
• reviewers exists

Thank you!

Comment 1

[Zeid Zabaneh [:zeid] (pto)]

Done: https://phabricator.services.mozilla.com/H376.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Hi Zeid, I'm trying to remove #devtools-reviewers of certain patch which has already been accepted and it automatically adds it back. Is this expected. Should i file a bug for it?

Comment 3

[Zeid Zabaneh [:zeid] (pto)]

:bomsy -- can you please link to the revision? I think I know why this is happening.

Comment 4

[Hubert Boma Manilla (:bomsy)]

This one for example https://phabricator.services.mozilla.com/D164727. It also happens on the others. We have to get the reviewers to accept again.
Thanks for taking a look.

Comment 5

[David Lawrence [:dkl]]

I think just changing the rule only fire once should be enough to fix this.

Comment 6

[Zeid Zabaneh [:zeid] (pto)]

:dkl -- updated the rule, hopefully this fixes it.

Comment 7

[Hubert Boma Manilla (:bomsy)]

Thanks it works now!