1820675 - [wpt-sync] Sync PR 38837 - Revert "Add :visited duplicate rules to regular buckets"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38837 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38837
Details from upstream follow.

Devlin Cronin <[e-mail]> wrote:

Revert "Add :visited duplicate rules to regular buckets"

This reverts commit dc5c40463c0b59bea1ed85c27f9b9d95a234ed9a.

Reason for revert: Suspecting this caused the test
EasySelectorCheckerTest.IsEasy to fail:

https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/111829/overview

Original change's description:

Add :visited duplicate rules to regular buckets

During RuleSet::AddRule, when adding a rule which depends on visited
link status, we add a duplicate rule (but with different a
LinkMatchType) to a special bucket for visited rules. However, this
approach does not quite work, since we depend on certain rules being
present in specific buckets in some situations. In particular, rules
which contain ::part() must be in the part bucket, because we don't
provide the relevant part names when when matching rules from other
buckets.

This CL drops the special 'visited_dependent_rules_' and instead
adds the duplicate rules via FindBestRuleSetAndAdd. Calling
FindBestRuleSetAndAdd on the duplicate RuleData could incorrectly
mark the selector as "covered by bucketing", so a BucketCoverage
parameter is added to suppress this behavior.

Note that the function StyleResolver::StyleRulesForElement (only
used for Editing) now needs to suppress :visited styles (see
SerializationTest.Link and crbug.com/938590), because we try to match
the visited-dependent rules regardless of the value of
ElementRuleCollector::inside_link_.

Fixed: 1413904
Change-Id: Id360bef4f1b977107f109c4520db08f6e602a034
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4295376
Auto-Submit: Anders Hartvoll Ruud \<[e-mail]>
Reviewed-by: Rune Lillesveen \<[e-mail]>
Commit-Queue: Rune Lillesveen \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1113519}

Change-Id: I8072cdb5a9d196c821b66e22dabd5500550f4bd7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4313026
Commit-Queue: Rubber Stamper \<[e-mail]>
Auto-Submit: Devlin Cronin \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Owners-Override: Devlin Cronin \<[e-mail]>
Commit-Queue: Devlin Cronin \<[e-mail]>
Reviewed-by: Devlin Cronin \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1113661}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 38837 applied with additional changes from upstream: af59415df8af0d0e85a21dcf78b8878a41e4ae2d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=c86a841a2e64ea03c1c74eec803080fb23f77468

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a1e19faa665
[wpt PR 38837] - Revert "Add :visited duplicate rules to regular buckets", a=testonly

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6a1e19faa665