1820709 - fix image draw flags in nsImageFrame in a few places

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1820709. Make nsDisplayAltFeedback::CreateWebRenderCommands sync decode just like nsDisplayAltFeedback::Paint. r?#layout-reviewers

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1820709. Make nsImageFrame use nsDisplayListBuilder::GetImageDecodeFlags. r?#layout-reviewers

This will mean we always pass FLAG_SYNC_DECODE_IF_FAST (unless we are already passing the sync decode flag). The fact that we weren't doing this already is an oversight, we want to do this for all images we paint on the normal painting path. However what makes this more important is that we folded nsImageBoxFrame into nsImageFrame recently (bug 1815229), and nsImageBoxFrame eagerly decodes all its images and keeps them decoded, and also uses FLAG_SYNC_DECODE_IF_FAST (because with multiple sized decodes eager decodes don't cover everything). So this should help us avoid regressing visually with xul images.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0f5af685009
Make nsDisplayAltFeedback::CreateWebRenderCommands sync decode just like nsDisplayAltFeedback::Paint. r=emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bfd8d7a043e
Make nsImageFrame use nsDisplayListBuilder::GetImageDecodeFlags. r=emilio

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f0f5af685009
https://hg.mozilla.org/mozilla-central/rev/8bfd8d7a043e