1820826 - `performance.mark` markers are wrongly positioned when { startTime } is used.

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P1)

Description

[Julien Wajsberg [:julienw]]

We insert the marker in this location: https://searchfox.org/mozilla-central/rev/3002762e41363de8ee9ca80196d55e79651bcb6b/dom/performance/Performance.cpp#349-351

We don't pass any timestamp, this means that the profiler subsystem will get one by itself. This is mostly correct in the usual case, but it's not if we use the form where the startTime is passed as a parameter:

performance.mark("mark-name", { startTime });

We should take it into account... but taking care that we don't have the same precision problem than in bug 1820813.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1820826 - Use the startTime in performance.mark API if it's provided in its options r?mstange

Depends on D173002

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ffc9e3d34e6
Use the startTime in performance.mark API if it's provided in its options r=mstange

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1ffc9e3d34e6