Slider debug code is built unnecessarily

RESOLVED FIXED

Status

()

Core
Layout: Misc Code
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Christopher Aillon (sabbatical, not receiving bugmail), Assigned: Christopher Aillon (sabbatical, not receiving bugmail))

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We curently define a symbol to PR_FALSE, then do a run-time check of the symbol.
 We should really only build the slider debug stuff if the symbol is set, and
don't build it otherwise.  Patch coming.
Fixed.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 3

16 years ago
Then again, the code generated was probably the same and we did get a compiler
check of the debug code. The GNU Coding Standards recommends doing what the
original code did when it's possible just so that the compiler can check the
alternative code too. It will be optimized away as dead code anyway.

You need to log in before you can comment on or make changes to this bug.