1820858 - [hazards] analysis assumes loops will always run at least once

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect, P1)

Description

[Steve Fink [:sfink] [:s:]]

This is problematic when looking at dominators, because it assumes the post-loop code is dominated by the loop body, which is incorrect.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1820858 - [hazards] Post-loop point should have pre-loop point as predecessor. It is not enough to eventually reach the point through the loop, because of dominator analyses.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2751ae76325c
[hazards] Post-loop point should have pre-loop point as predecessor. It is not enough to eventually reach the point through the loop, because of dominator analyses. r=jonco

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for causing hazard failures on rootAnalysis/analyze.py

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=2751ae76325c35a84d5781d1f507210cdbd72159&selectedTaskRun=M9SJI8SYQGaNn2E9N2IxfQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=412108269&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/79b976bdc2330d5df519bdd325b0a988fb02878e

Comment 4

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/79b976bdc233

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3099900e3b34
[hazards] Post-loop point should have pre-loop point as predecessor. It is not enough to eventually reach the point through the loop, because of dominator analyses. r=jonco

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3099900e3b34