Closed
Bug 1820897
Opened 2 years ago
Closed 2 years ago
[Tabs tray to Compose] Disable `Theme.Private` from being used in Tabs Tray
Categories
(Firefox for Android :: Tabs, task, P3)
Tracking
()
RESOLVED
FIXED
113 Branch
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: 007, Assigned: 007)
References
Details
(Whiteboard: [fxdroid])
Attachments
(1 file)
Double check with UX to confirm if only Light/Dark theming should be used on the Tabs Tray.
To achieve the desired effect here, change the FirefoxTheme line in TabsTrayFragment from:
FirefoxTheme { ... }
to:
FirefoxTheme(Theme.getTheme(allowPrivateTheme = false)) { ... }
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → nbond
|
|
Assignee | |
Updated•2 years ago
|
Whiteboard: [fxdroid]
|
||
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•2 years ago
|
||
I confirmed with UX that the Tabs Tray should only be using the Light/Dark themes in the entirety of the Tabs Tray. This may change at a later date, but it will be fairly trivial to allow the Private theme color tokens to be used.
|
||
Comment 2•2 years ago
|
||
|
|
||
Comment 3•2 years ago
|
||
Authored by https://github.com/MozillaNoah
https://github.com/mozilla-mobile/firefox-android/commit/cecb1a9119e321cd2ca6c85d8562d8eafad1eccf
[main] Bug 1820897 - Disable the private theme from being used in the Composified Tabs Tray
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox113:
--- → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
|
|
Assignee | |
Updated•2 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•