1820926 - Pocket newtab Discovery Stream topsites image issues

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Scott [:thecount] Downe]

Seems there are issues with the image from Discovery Stream.

There are a few layers, but the 2 main ones are:

1. Moving the DIscovery Stream topsites to load early exposed some processing to the url because it was set as a customScreenshotURL previously it would skip the extra processing because it was inserted later. Fix is to not use customScreenshotURL and instead use favicon.
2. Favicon has a parsing issues because the quote usage was a bit wonky, but wasn't hard to fix it when we setup the favicon by adding the right quotes to ensure it can be parsed properly.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1820926 - Pocket newtab fixing Discovery Stream topsite images.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30706372b15a
Pocket newtab fixing Discovery Stream topsite images. r=nanj

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/30706372b15a