1821039 - "script.callFunction" has to fail with "no such handle" error if the handle of an object as passed as argument is unknown

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

As per the WebDriver BiDi spec the handle of an object needs to be known if given. If it's not known within the given Realm, a no such handle error needs to be raised.

Right now we raise an invalid argument error instead. When fixing that we need browser chrome as well as wdspec tests.

Comment 1

[Saira]

I would like to attempt this. Can you please guide me?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Sure, and thank you for your interest! In the following some information in how to get this fixed.

An example of using a handle can be found in the webdriver BiDi tests for callFunction within arguments.py. It basically means that a strong reference of a Javascript object gets created within the browser by some script evaluation, which then later on can be referred via callFunction.

Steps to do here would be:

1. Create a new test within invalid.py right under the test test_params_arguments_handle_invalid_type and name it test_params_arguments_handle_unknown_value. Here a string value needs to be passed as handle to callFunction that is randomly set, eg. foo.

2. Run the given test by specifying the exact path and notice that it doesn't fail with a no such handle failure but invalid argument.

3. Fix the problem with the deserialization in RemoteValue.sys.mjs so that the correct error is thrown. It needs to behave similar as InvalidArgumentError.

4. Ensure to also add the new error type to the WebDriver BiDi Python client so that the test can correctly assert the expected error type.

If you have questions don't hesitate to ask, or even better join us on Matrix in the webdriver channel.

Comment 3

[Saira]

Attachment: Bug 1821039 - 'script.callFunction' has to fail with 'no such handle' error if the handle of an object as passed as argument is unknown. r?whimboo

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/513e167dd843
'script.callFunction' has to fail with 'no such handle' error if the handle of an object as passed as argument is unknown. r=whimboo,webdriver-reviewers

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39404 for changes under testing/web-platform/tests

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Attachment: Bug 1821039 - [webdriver-bidi] Fix broken object handle tests in browser_RemoteValue.js.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b9301f49922
[webdriver-bidi] Fix broken object handle tests in browser_RemoteValue.js. r=webdriver-reviewers,jdescottes

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/513e167dd843
https://hg.mozilla.org/mozilla-central/rev/3b9301f49922

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham