182108 - Get New Themes/Extensions Links in Preferences point to outdated URLs

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Simon Paquet [:sipaq]]

This is a leftover of bug 181994

The "Get new Themes"-link right now points to http://mozilla.org/themes/download
when it should instead point to http://texturizer.net/phoenix/themes.html just
like in the default bookmarks.

The "Get new extensions"-link right now points to
http://www.mozilla.org/projects/phoenix/extensions/ when it should instead point
to http://texturizer.net/phoenix/extensions.html just like in the default bookmarks.

Assigning to myself.

Comment 1

[David Tenser [:djst]]

Isn't this a dupe of bug 180844, which is marked as NEW? Why is this extra bug
report about the same thing needed?

Comment 2

[Simon Paquet [:sipaq]]

Both bugs are about different thing. Bug 180844 is about both links opening
blank windows, while this bug is about both links pointing to a different
location. But these new links won't work until bug 180844 is fixed, which is why
I will mark bug 180844 blocking this bug. I had forgotten that yesterday evening.

Comment 3

[Simon Paquet [:sipaq]]

Make this bug a blocker for bug 182110 because of patch dependencies.

Comment 4

[Simon Paquet [:sipaq]]

Attachment: Patch for region.dtd

Comment 5

[Simon Paquet [:sipaq]]

Attachment: Path for pref-themes.xul

The "Get new Extensions"-URL was hardcoded into pref-themes.xul, which is bad.
Moving this URL to region.dtd. The corresponding patch to region.dtd already
reflects this change.

Comment 6

[Simon Paquet [:sipaq]]

Attachment: Unified patch

Stupid me! Why make two patches, if one is enough. Sorry for bugspam.

Comment 7

[Asa Dotzler [:asa]]

actually, we need to set this up to point to a mozilla.org url that can redirect
to the appropriate site. It would suck if we had a million phoenix users and the
load was too much for texturizer or David decided he hated Phoenix and moved on
;-) leaving millions of users with a dead link. 
I haven't set up the page that would redirect phoenix themes to David's site but
I can try to get something up soon. 
I'm not opposed to hardcoding in the leading themes site today but before we
ship anything that can be considered even close to 1.0 we really should get this
done right.

Comment 8

[Simon Paquet [:sipaq]]

Whichever location we choose... The URLs should be in region.dtd and not in
pref-themes.xul, as is the case with the extension URL. This is one of two
aspects of this bug.

Changing the URL is pretty simple and can easily be done.

Comment 9

[Simon Paquet [:sipaq]]

Blake fixed this in bug 180844.

Comment 10

[David Tenser [:djst]]

I think this should wait until the new name is chosen. texturizer.net/phoenix
will then be changed to texturizer.net/newname.

Btw, why is it resolved as FIXED?

Comment 11

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 12

[Simon Paquet [:sipaq]]

Verified

Comment 13

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change