1821163 - Convert browser/actors/Plugin* JSMs to ESMs

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[kpatenio]

The JSM modules in browser/actors requiring conversion:

• https://searchfox.org/mozilla-central/rev/cd2121e7d83af1b421c95e8c923db70e692dab5f/browser/actors/PluginChild.jsm
• https://searchfox.org/mozilla-central/rev/cd2121e7d83af1b421c95e8c923db70e692dab5f/browser/actors/PluginParent.jsm

Please see our ESMification guide on how to convert these modules.

Comment 1

[Abhishek[: unavailable till 11 May]]

Attachment: Bug 1821163 - Convert browser/actors/Plugin* JSMs to ESMs r=kpatenio

Depends on D172095

Comment 2

[Abhishek[: unavailable till 11 May]]

Sir, I accidentally deleted my last dev setup, so I am making a new patch for it and will abandon this patch

Comment 3

[Abhishek[: unavailable till 11 May]]

Attachment: Bug 1821163 - Convert browser/actors/Plugin* JSMs to ESMs r=kpatenio

Comment 4

[kpatenio]

Hi Abhishek - your patch is currently set to WIP (work in progress). When a patch is set to WIP, no emails will be sent to you and reviewers when there's changes to your patch. Can you please change the status to "needs review"? There should be an option in Phabricator to request review (see the "Add Action" dropdown).

Also just a FYI for future work - you don't need to submit a new patch if you lose your local repository. You can run moz-phab patch --apply-to <revision like central, for example> to pull your patch changes and apply it into your local workspace. When you submit, it will update the same patch.

Comment 5

[Abhishek[: unavailable till 11 May]]

Sir, I apologise for the too-late reply, and while correcting it, I got this message - !! "Changes Planned" status will change to "Request Review"
Warning: found 18 untracked files (will not be submitted):
I simply click enter after this. Please check if I made any mistakes.
Thanks

Comment 6

[Abhishek[: unavailable till 11 May]]

Attachment: Bug 1821163 - Convert browser/actors/Plugin* JSMs to ESMs r=kpatenio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/defb830e2ecf
Convert browser/actors/Plugin* JSMs to ESMs r=kpatenio

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/defb830e2ecf