1821208 - [wpt-sync] Sync PR 38899 - Revert "Consistency check between AXObjectCacheImpl and AXTreeSerializer tree"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38899 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38899
Details from upstream follow.

Alvin Jia <[e-mail]> wrote:

Revert "Consistency check between AXObjectCacheImpl and AXTreeSerializer tree"

This reverts commit 505abab46074b91eb632e60d0d63b5e082282f83.

Reason for revert: breaking Crostini tests

Original change's description:

Consistency check between AXObjectCacheImpl and AXTreeSerializer tree

This is the lite version of checking the entire tree structure, only checking that the number of nodes is the same. It's easier to do and a more performant check. This CL only adds the checks. Four precursor CLs were landed to clean up object leaks and tree inconsistencies so that these checks would pass: AXMenuList (CL:4289642), Slots (CL:4294848), Image maps (CL:4291697), Inline text boxes (CL:4289593).

Follow up: a future check should be added to check for consistency between AXTreeSerializer and AXTree.

Bug: none
Change-Id: I0f33f9f7bdcd3f70cfce9182ab1111c7dfec6236
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4185240
Reviewed-by: David Tseng \<[e-mail]>
Commit-Queue: Aaron Leventhal \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1114055}

Bug: none
Change-Id: Icddc46ec3868826a700ece8defa174c003cfbf7a

Reviewed-on: https://chromium-review.googlesource.com/4322517
WPT-Export-Revision: 9ecbd9ba72f62bc28ad48343dbe6514ce8b88a3e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 38899 applied with additional changes from upstream: 4b3af57a11a724363f9563744a16e4d763885adc

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=97ae557466b23aa69aa3e67058a9255c101c15b8

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c978a659b0d
[wpt PR 38899] - Revert "Consistency check between AXObjectCacheImpl and AXTreeSerializer tree", a=testonly

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3c978a659b0d