Convert toolkit/components/corroborator/ to ES modules
Categories
(Toolkit :: General, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: standard8, Assigned: tiwari.abhishektiwari23, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [esmification-timeline][lang=js])
Attachments
(1 file, 1 obsolete file)
I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it. You'll be automatically assigned when you upload the first patches.
Here's what to do:
- Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
- If you need help setting up, ask in #introduction on Matrix
- Using the ESMification walkthrough as a guide:
- Run
./mach esmify --convert path/to/files
- Examine the output for any errors from ESLint and fix them.
- Next convert the imports -
./mach esmify --import . --prefix path/to/files
- Again, check for any errors and fix them.
- Run a build to check it passes.
- Also run
./mach eslint --fix path/to/files
and check there are no raised failures - Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
- Run
- Use
moz-phab submit
to submit the patches for review.
Assignee | ||
Comment 1•2 years ago
|
||
Hello sir. This task is similar to the previous task that I completed. In the task review of previous patches, you mentioned I to merge all in a single commit, so Can I merge all the previous commits in this?
Reporter | ||
Comment 2•2 years ago
|
||
(In reply to Abhishek from comment #1)
Hello sir. This task is similar to the previous task that I completed. In the task review of previous patches, you mentioned I to merge all in a single commit, so Can I merge all the previous commits in this?
Please keep different bugs separate. Generally you only need one or two commits per bug.
Assignee | ||
Comment 3•2 years ago
|
||
Sir, this is a doubt whether I am on the right track or not. I make a new branch for each bug named - Bug#nnnn and then make changes in that branch and mark a patch after that. Is it the correct way, or should I change my approach? It is similar to GitHub but new. I would appreciate your suggestion.
Assignee | ||
Comment 4•2 years ago
|
||
Depends on D172128
Updated•2 years ago
|
Assignee | ||
Comment 5•2 years ago
|
||
I have deleted the previous file I was working on, so I am making a new patch for this one. Thanks
Assignee | ||
Comment 6•2 years ago
|
||
Updated•2 years ago
|
Comment 8•2 years ago
|
||
bugherder |
Description
•