Closed Bug 1821302 Opened 1 year ago Closed 1 year ago

Convert toolkit/components/corroborator/ to ES modules

Categories

(Toolkit :: General, task, P3)

task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: standard8, Assigned: tiwari.abhishektiwari23, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [esmification-timeline][lang=js])

Attachments

(1 file, 1 obsolete file)

I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it. You'll be automatically assigned when you upload the first patches.

Here's what to do:

  • Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • Using the ESMification walkthrough as a guide:
    1. Run ./mach esmify --convert path/to/files
    2. Examine the output for any errors from ESLint and fix them.
    3. Next convert the imports - ./mach esmify --import . --prefix path/to/files
    4. Again, check for any errors and fix them.
    5. Run a build to check it passes.
    6. Also run ./mach eslint --fix path/to/files and check there are no raised failures
    7. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
  • Use moz-phab submit to submit the patches for review.

Hello sir. This task is similar to the previous task that I completed. In the task review of previous patches, you mentioned I to merge all in a single commit, so Can I merge all the previous commits in this?

(In reply to Abhishek from comment #1)

Hello sir. This task is similar to the previous task that I completed. In the task review of previous patches, you mentioned I to merge all in a single commit, so Can I merge all the previous commits in this?

Please keep different bugs separate. Generally you only need one or two commits per bug.

Sir, this is a doubt whether I am on the right track or not. I make a new branch for each bug named - Bug#nnnn and then make changes in that branch and mark a patch after that. Is it the correct way, or should I change my approach? It is similar to GitHub but new. I would appreciate your suggestion.

Assignee: nobody → tiwari.abhishektiwari23
Status: NEW → ASSIGNED

I have deleted the previous file I was working on, so I am making a new patch for this one. Thanks

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f9132f29250
Convert toolkit/components/corroborator/ to ES modules updated r=Standard8
Attachment #9322138 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: