1821450 - Simplify the contain keyword for ray function

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Boris Chiou [:boris]]

Per spec issue: https://github.com/w3c/fxtf-drafts/issues/363, there is a update for contain keyword. Basically it simplify the math calculation and has some impact on the behavior of animations. We should update the implementation once this spec issue gets resolved.

Comment 1

[Boris Chiou [:boris]]

The Chromium patch and WPT update: https://chromium-review.googlesource.com/c/chromium/src/+/4453583

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1821450 - Update the calculation of contain keyword in ray().

Per the spec change, when using contain keyword, the path’s length is reduced
by half the width or half the height of the element’s border box, whichever is
larger, and floored at zero.

Tests are in WPT: css/motion/offset-path-ray-contain-00*.html.

Note that these tests are failed because we haven't synced with WPT repo.
After our WPT gets synced, all tests will be passed.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1821450 - Factor out the calculation of reference box in TransformReferenceBox.

For motion ray() with contain keyword, we are always using
the width and height of the border-box. So this patch makes us easier to
get the border-box dimension from TransformReferenceBox no matter what
transform-box we set.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29fa69db2655
Update the calculation of contain keyword in ray(). r=emilio

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/29fa69db2655