1821574 - Two pixel gap between Spaces Toolbar and Folder Pane with > 100% display scaling on Linux

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Meichthys]

Attachment: Spaces-Folders-Gap.png

Steps to reproduce:

Close and re-open Spaces toolbar.
I'm on Linux Plasma desktop with Thunderbird 111.0b3 (64-bit)

Actual results:

A small gap appears between spaces toolbar and folder pane.
Usually the gap can be fixed by moving the window or re-opening spaces toolbar

Expected results:

No gap should appear.

Comment 1

[Thomas D. (:thomas8)]

Probably Linux-only, not seeing this on 113.0a1 (2023-03-20) (64-bit), Win10.
Meichthys, do you use display scaling of some sort?

Comment 2

[Meichthys]

I can't remember if this was on Windows or Linux. I do use both, and on Linux i do use display scaling, so i think we can chalk it up to that 👍

Comment 3

[Meichthys]

To follow up here, i can reproduce this on Linux when scaling is set to something above 100%.
Probably no need too re-open this since it's an edge case related too the OS.

Comment 4

[Wayne Mery (:wsmwk)]

Should this be happening/reopen?

Comment 5

[Alessandro Castellani [:aleca]]

This obviously shouldn't happen.
I can't reproduce it on elementary OS, which is GTK based.
In the original message it says "Linux Plasma desktop", which is Qt based, so very different. And there's also the fractional scaling scenario to consider, which behaves differently between X11 and Wayland.

Let's see if Micah or Richard can reproduce this and maybe find a solution.

Comment 6

[Meichthys]

For reference, I was still using X11.
BTW, I liked the podcast 👍

Comment 7

[Richard Marti (:Paenglab)]

I don't see this. Maybe it's an issue with the width calculation for --spaces-total-width.

Comment 8

[Meichthys]

Richard,
For me it sometimes requires some playing with the sidebar. If i hide the sidebar and then restore it, resize the window, or minimize/reopen can sometimes trigger the issue.

Comment 9

[[e-mail]]

I was unable to reproduce on Fedora 37 (GNOME) on wayland or x11 at 100% or 200% scale.

Comment 10

[Thomas D. (:thomas8)]

I believe that this happens under certain circumstances, but if no one is able to reproduce, looks like this is going nowhere, which is worksforme... (trivial issue, minimally odd, but not detrimental).

Comment 11

[Alessandro Castellani [:aleca]]

I was able to reproduce it on Windows at 150% scaling and a ltw-theme.
I have a fix!

Comment 12

[Alessandro Castellani [:aleca]]

Attachment: Bug 1821574 - Remove the 1px extra spacing from the space toolbar width. r=#thunderbird-front-end-reviewers

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a576d9924e3b
Remove the 1px extra spacing from the space toolbar width. r=Paenglab

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9340808 [details]
Bug 1821574 - Remove the 1px extra spacing from the space toolbar width. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 15

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/8d90aa02d20e