1821618 - [wayland] Date picker closes and reopens with just one click on the date field

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Bogdan Maris, Desktop QA]

Attachment: Gif showing the issue

Found in

• Latest Nightly 112.0a1

Affected versions

• Latest Nightly 112.0a1
• Firefox 111.0 RC (wayland only)

Tested platforms

• Affected platforms: Ubuntu 22.04
• Unaffected platforms: Windows 10, macOS 13

Steps to reproduce

1. Visit https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date
2. Have the date field from Try it or Value at the bottom of the visible page and on the bottom of the OS window so that the date picker to open above the field.
3. Click the calendar icon a few times

Expected result

• After 1 click the picker opens, after the second click the picker is closed and so on.

Actual result

• The picker closes and opens over and over again with each click on the calendar icon.

Regression range

• First bad: de341533273c307ae02d0b32635ad97fdce684ff
• Last good: 5ddeabd60a3ceacb071fe392982484be50e49987
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5ddeabd60a3ceacb071fe392982484be50e49987&tochange=de341533273c307ae02d0b32635ad97fdce684ff
• Potentially regressed by: Bug 1808962 - Always honor move-to-rect positioning requests.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Not really a regression. Before that patch the popup didn't show up at all.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1821618 - Make norolluponanchor="true" work on Wayland moved-to-rect popups. r=stransky

Use the unstransformed anchor rect to get the right original anchor
rect.

Comment 3

[Bogdan Maris, Desktop QA]

Attachment: Behavior before bug 1808962.gif

For me, using an old Nightly build right before bug 1808962 got fixed the picker did not appear if I kept my cursor on the calendar icon, but if I hovered over the area where the picker should appear the picker blinked there a few times indicating that it was there. If I clicked the second time on the calendar icon and hovered over the area where the picker should appear it would have not, and that behavior started after fixing bug 1808962 based on mozregression. Not saying that this is a regression from bug 1808962 but this behavior for sure started after that bug was fixed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0043ebcb10f2
Make norolluponanchor="true" work on Wayland moved-to-rect popups. r=stransky

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for causing pop-up failures.

• backout: https://hg.mozilla.org/integration/autoland/rev/a8939ff5236dad956af827235ceed7104e5e92c2
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=0043ebcb10f26b687dd6587918a8f83192bd523f&selectedTaskRun=BnXU5hfvT7SQN6Ff_mOWEg.0
• failure log: https://treeherder.mozilla.org/logviewer?job_id=408656198&repo=autoland&lineNumber=122255

[task 2023-03-12T13:13:11.262Z] 13:13:11     INFO - TEST-PASS | layout/xul/test/test_bug987230.xhtml | Popup hidden 
[task 2023-03-12T13:13:11.268Z] 13:13:11     INFO - Mousemove: 617, 235 (from innerscreen 13, 335 and rect width 504 and scale 1)
[task 2023-03-12T13:13:11.279Z] 13:13:11     INFO - GECKO(3572) | MEMORY STAT | vsize 2112723MB | vsizeMaxContiguous 65951307MB | residentFast 347MB | heapAllocated 121MB
[task 2023-03-12T13:13:11.290Z] 13:13:11     INFO - TEST-INFO | started process screenshot
[task 2023-03-12T13:13:11.362Z] 13:13:11     INFO - TEST-INFO | screenshot: exit 0
[task 2023-03-12T13:13:11.378Z] 13:13:11     INFO - Buffered messages logged at 13:13:11
[task 2023-03-12T13:13:11.378Z] 13:13:11     INFO - click: hbox-anchor
[task 2023-03-12T13:13:11.378Z] 13:13:11     INFO - Buffered messages finished
[task 2023-03-12T13:13:11.379Z] 13:13:11     INFO - TEST-UNEXPECTED-FAIL | layout/xul/test/test_bug987230.xhtml | Popup should only be shown once 
[task 2023-03-12T13:13:11.379Z] 13:13:11     INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:421:16
[task 2023-03-12T13:13:11.379Z] 13:13:11     INFO - onAnchorClick@chrome://mochitests/content/chrome/layout/xul/test/test_bug987230.xhtml:89:7
[task 2023-03-12T13:13:11.379Z] 13:13:11     INFO - onclick@chrome://mochitests/content/chrome/layout/xul/test/test_bug987230.xhtml:1:14
[task 2023-03-12T13:13:11.380Z] 13:13:11     INFO - TEST-OK | layout/xul/test/test_bug987230.xhtml | took 218ms
[task 2023-03-12T13:13:11.380Z] 13:13:11    ERROR - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/test/test_bug987230.xhtml logged result after SimpleTest.finish(): Popup should only be shown once

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c09acfb76257
Make norolluponanchor="true" work on Wayland moved-to-rect popups. r=stransky

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c09acfb76257

Comment 8

[Bogdan Maris, Desktop QA]

Looks fixed to me in latest Nightly 113.0a1 using Ubuntu 22.04.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

(per comment 8)

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9322384 [details]
Bug 1821618 - Make norolluponanchor="true" work on Wayland moved-to-rect popups. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple change to account for Wayland special case.
• String changes made/needed: none
• Is Android affected?: No

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9322384 [details]
Bug 1821618 - Make norolluponanchor="true" work on Wayland moved-to-rect popups. r=stransky

Approved for 112.0b3

Comment 13

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0cd34af62720

Comment 14

[Negritas Sergiu, Desktop QA]

Hello! I have managed to reproduce the issue with firefox 112.0b2 on Ubuntu 22.04 wayland, I can confirm that the issue is fixed with firefox 112.0b3 from treeherder ( https://treeherder.mozilla.org/jobs?repo=mozilla-beta ) on Ubuntu 22.04 wayland. I will mark this issue as VERIFIED->FIXED and update the flags.

Have a nice day!