1821660 - Perma Late Beta browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js when Gecko 112 switches to Late Beta 2023-02-24

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Sandor Molnar[:smolnar]]

Central-as-Beta simulation

How to run these simulations

Failure log

INFO - TEST-PASS | browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js | groups is correct - "" == "" - 
[task 2023-03-10T12:20:34.047Z] 12:20:34     INFO - Buffered messages logged at 12:18:27
[task 2023-03-10T12:20:34.047Z] 12:20:34     INFO - Console message: [JavaScript Error: "1678450707340	addons.xpi	ERROR	System addon update list error Error: got node name: html, expected: updates" {file: "resource://gre/modules/Log.sys.mjs" line: 722}]
[task 2023-03-10T12:20:34.047Z] 12:20:34     INFO - append@resource://gre/modules/Log.sys.mjs:722:12
[task 2023-03-10T12:20:34.048Z] 12:20:34     INFO - log@resource://gre/modules/Log.sys.mjs:376:16
[task 2023-03-10T12:20:34.048Z] 12:20:34     INFO - error@resource://gre/modules/Log.sys.mjs:384:10
[task 2023-03-10T12:20:34.048Z] 12:20:34     INFO - updateSystemAddons/res<@resource://gre/modules/addons/XPIInstall.jsm:4104:25
[task 2023-03-10T12:20:34.048Z] 12:20:34     INFO - 
[task 2023-03-10T12:20:34.048Z] 12:20:34     INFO - Buffered messages finished
[task 2023-03-10T12:20:34.048Z] 12:20:34     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js | Test timed out - 
[task 2023-03-10T12:20:34.436Z] 12:20:34     INFO - GECKO(5454) | MEMORY STAT | vsize 130551597MB | residentFast 1348MB
[task 2023-03-10T12:20:34.438Z] 12:20:34     INFO - TEST-OK | browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js | took 240703ms

Comment 1

[Sandor Molnar[:smolnar]]

@Daisuke, can you take a look at this perma beta-sim failure?
Can't figure out if it's coming from bug 1817206 or bug 1820453

Comment 2

[Daisuke Akatsuka (:daisuke)]

Thanks, Sandor!
I will take a look at this issue.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1821660: Avoid showing result view to make the same behavior every time.

Comment 4

[Serban Stanca [:SerbanS]]

The patch does not seem to work in today's central as beta simulation. Could you please take another look at this?

Comment 5

[Daisuke Akatsuka (:daisuke)]

Hi Serban! Thank you very much for letting me know.

I have one question about how to test on the Beta.
I threw my latest patch to the try by ./mach try release --version 112.0b12 --migration central-to-beta command.
https://treeherder.mozilla.org/jobs?repo=try&revision=0075c0488032598014fa42b91213ed4f8dcca420
It seems that there is no problem in the above try. But, maybe, what I did was wrong?
If possible, could you let me know how to throw to try to test Beta?
And also, if you know how to build Beta locally, please let me know.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This needs one more migration:
./mach try release -v 113.0b12 --tasks release-sim --migration central-to-beta --migration early-to-late-beta (version adjusted for yesterday's version increase)

Comment 7

[Daisuke Akatsuka (:daisuke)]

I will try it! Thank you very much for your quick response!

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1817206

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf0aeedfede3
Avoid showing result view to make the same behavior every time. r=mak

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/cf0aeedfede3

Comment 11

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/32bc0e19204c

Comment 12

[Cristina Horotan [:chorotan]]

Verified as fixed with this beta sim