"Javascript" should be "JavaScript " and more...

VERIFIED FIXED

Status

SeaMonkey
UI Design
VERIFIED FIXED
15 years ago
13 years ago

People

(Reporter: Henrik Gemal, Assigned: Henrik Gemal)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.12 KB, patch
Christopher Aillon (sabbatical, not receiving bugmail)
: review+
Alec Flett
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
In the debug panel it says:
"Show Javascript errors and warnings in Mozilla chrome in the js console"

lets change this to:
"Show JavaScript errors and warnings in chrome"

everybody knows that the warnings are located in the console and JavaScript is
spelled with capital S and it's not only Mozilla chrome. It's also chrome for
installed applications like calendar stuff from mozdev etc...

Patch coming...
(Assignee)

Comment 1

15 years ago
Created attachment 107578 [details] [diff] [review]
patch to fix wording. No code change...
(Assignee)

Updated

15 years ago
Attachment #107578 - Flags: review?
(Assignee)

Updated

15 years ago
Attachment #107578 - Flags: review? → review?(sgehani)
Comment on attachment 107578 [details] [diff] [review]
patch to fix wording. No code change...

r=glazman
Attachment #107578 - Flags: review?(sgehani) → review+
(Assignee)

Comment 3

15 years ago
rs=brendan since this is wording only

checkin anyone?
Attachment #107578 - Flags: superreview+
Comment on attachment 107578 [details] [diff] [review]
patch to fix wording. No code change...

>Index: mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-debug.dtd

>-<!ENTITY debugConsoleJavascript.label    "Show Javascript errors and warnings in Mozilla chrome in the js console">
>+<!ENTITY debugConsoleJavascript.label    "Show JavaScript errors and warnings in chrome">

If you were changing just Javascript -> JavaScript I would say ok, and land
this, but if you are making changes like this, please make sure to get a module
owner or peer to look at this.

I think that the new wording may be somewhat misleading.  It could very easily
be construed that the chrome is where the errors and warnings will be shown
(ala: Show "The Two Towers" in theaters, Show the clip in Windows Media Player,
etc...) Perhaps better wording would be along the lines of "Show chrome
JavaScript errors and warnings"?
(Assignee)

Comment 5

15 years ago
Created attachment 107687 [details] [diff] [review]
new and better patch

good points. thanx!
text is now "Show chrome JavaScript errors and warnings"
Attachment #107578 - Attachment is obsolete: true
Comment on attachment 107687 [details] [diff] [review]
new and better patch

r=caillon
Attachment #107687 - Flags: review+
(Assignee)

Updated

15 years ago
Attachment #107687 - Flags: superreview?(dveditz)
(Assignee)

Comment 7

15 years ago
Comment on attachment 107687 [details] [diff] [review]
new and better patch

please review ths small wording cleanup
Attachment #107687 - Flags: superreview?(dveditz) → superreview?(alecf)

Comment 8

15 years ago
Comment on attachment 107687 [details] [diff] [review]
new and better patch

sr=alecf but next time please just roll something like this into a bigger patch
- its really a waste of my time and yours to have a whole seperate review for a
single character string change.
Attachment #107687 - Flags: superreview?(alecf) → superreview+
(Assignee)

Comment 9

15 years ago
timeless: can you checkin?
(Assignee)

Comment 10

15 years ago
need checkin...:)

Comment 11

15 years ago
done
Assignee: sgehani → bugzilla

Comment 12

15 years ago
This was fixed a while ago...
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 13

15 years ago
verified code fix
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.