1821748 - nsRFPService registers for 1s user idle notifications but does nothing with them

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Florian Quèze [:florian]]

I noticed in a profile of a recent build that the user idle service was adding timers all the time for short durations. After some investigation, I found that nsRFPService adds a 1s idle observer.

When looking at the code in https://phabricator.services.mozilla.com/D170603, it seems there was some confusion between user idle observers and observing the idle-daily notification from the regular observer service.
The code doesn't seem to do anything when receiving an "idle" notification (the OBSERVER_TOPIC_IDLE topic isn't used anywhere in the file, instead the OBSERVER_TOPIC_IDLE_DAILY topic is used, but no observer was added for that topic).

Maybe some leftover from a previous version of the patch?

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1821748 - make nsRFPService observe the idle-daily notification, r=tjr.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1816064

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a45d1cbb8fa8
make nsRFPService observe the idle-daily notification, r=timhuang.

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a45d1cbb8fa8

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 9322462 [details]
Bug 1821748 - make nsRFPService observe the idle-daily notification, r=tjr.

Beta/Release Uplift Approval Request

• User impact if declined: The user idle service will work harder than needed, resulting in more CPU wake-ups and higher power use.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is a simplification of the code that landed in Firefox 112. This code is pref'ed off by default (privacy.resistFingerprinting.randomization.daily_reset.enabled and privacy.resistFingerprinting.randomization.daily_reset.private.enabled set to false), but we still pay the performance cost of the CPU wake-ups.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9322462 [details]
Bug 1821748 - make nsRFPService observe the idle-daily notification, r=tjr.

Approved for 112.0b2

Comment 7

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/88f9f5bfa215