1821951 - [CTW] Remove HyperTextAccessible methods that call HyperTextAccessibleBase

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

There are several methods in HyperTextAccessible which delegate to HyperTextAccessibleBase if the cache is enabled. These include TextAtOffset, TextBeforeOffset, TextAfterOffset and Attributes, but there'll probably be others before we get to this. There are also helper methods that these depend on that aren't used by anything else; e.g. FindOffset, FindLineBoundary, FindWordBoundary, FindParagraphStart/EndOffset. Once we're ready to remove the legacy implementation, we should just remove these methods altogether. This also means they no longer need to be virtual in HyperTextAccessibleBase.

Comment 1

[James Teh [:Jamie]]

Note that bug 1384606 will implement a PeekOffset flag that is now only needed for HyperTextAccessible::FindOffset. We should remove that as well.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1821951 part 1: Remove HyperTextAccessible methods that are no longer needed now that the cache is always used.

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1821951 part 2: Remove PeekOffsetOption::AllowContentInDifferentNativeAnonymousSubtreeRoot.

This was only added for a11y and a11y no longer needs it.
Note that the code in Mac HyperTextAccessibleWrap which used this is no longer used itself and will be removed in bug 1821965.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d15074461aeb
part 1: Remove HyperTextAccessible methods that are no longer needed now that the cache is always used. r=morgan,taskgraph-reviewers,bhearsum
https://hg.mozilla.org/integration/autoland/rev/397196f3998e
part 2: Remove PeekOffsetOption::AllowContentInDifferentNativeAnonymousSubtreeRoot. r=eeejay,masayuki,taskgraph-reviewers,bhearsum

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d15074461aeb
https://hg.mozilla.org/mozilla-central/rev/397196f3998e