1821961 - Improve collapse animation of the tabs tray FAB & scrim

Status: VERIFIED FIXED

(Firefox for Android :: Tabs, enhancement, P2)

Description

[Joe M [:jmahon]]

Attachment: tab-tray-collapse.mp4

From :verdi:

The collapse of the tab tray is nice a smooth now. But after seeing it in action, it seems to accentuate the delay of the removal of the scrim and FAB. We'd like to have the FAB animate out with the tray and the scrim to dissolve at the same time. I mocked it up in a video to help explain.

Comment 2

[Joe M [:jmahon]]

:verdi - the last moments of that video have a "correct" animation - how did you accomplish that? Was that something you mocked up manually?

Comment 3

[Verdi [:verdi] Best to slack me]

(In reply to Joe M [:jmahon] from comment #2)

:verdi - the last moments of that video have a "correct" animation - how did you accomplish that? Was that something you mocked up manually?

Yes - via the magic of animation :)

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1821961 - Improve collapse animation of the tabs tray FAB & scrim (#1366)

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1821961 - Updated the collapse animation of the tabs tray FAB & scrim (#1695)

Comment 6

[Joe M [:jmahon]]

(Commenting here instead of on the PR because I don't want this to accidentally be construed as a code review)

Tom - the screen recording in the PR seems SO much smoother, at least to my untrained eye - well done! I just wanted to leave a note to make sure that you ping :verdi for him to look at it at some point, as well.

Comment 7

[Verdi [:verdi] Best to slack me]

Commented on the PR - looks great!

Comment 8

[BMO Github Automation]

Authored by t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/444597ebd585d3f318401ea44dc4cf268102b550
[main] Bug 1821961 - Updated the collapse animation of the tabs tray FAB & scrim

Comment 9

[Andrei Mocirean]

Verified as fixed on the latest Nightly (114.0a1) from 5th of May 2023.
The "new tab" button is going down along the rest of the elements present in Tabs Tray, as shown in the attachment.

Devices used for testing: Google Pixel 7 Pro (Android 13), OnePlus 5 (A5000) (Android 10)
Thank you!

Comment 10

[Verdi [:verdi] Best to slack me]

Thanks everyone!