Closed Bug 1821972 Opened 1 year ago Closed 10 months ago

Remove mscom stuff that was only used by non-caching legacy accessibility implementation

Categories

(Core :: IPC: MSCOM, task)

Desktop
Windows
task

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: Jamie, Assigned: Jamie)

References

Details

(Whiteboard: [ctw-postship])

Attachments

(2 files)

Once we always use the accessibility cache, we can remove a lot of ipc/mscom, including Interceptor, InterceptorLog, Handler, MainThreadHandoff, DispatchForwarder, MainThreadInvoker, SpinEvent, FastMarshaler, StructStream, PassthruProxy, VTableBuilder, ProxyStream, RegistrationAnnotator, AsyncInvoker, and a bunch of dependencies of those things.

We do not want to remove ProfilerMarkers, as these are used to highlight uses of synchronous outgoing COM that should not be occurring on the main thread.

Assignee: nobody → jteh

Regarding LazyInstantiator::ResolveDispatch, we already had code in MsaaAccessible to get the IAccessible typelib.
mscom::RegisterTypelib has a lot of dependencies and it doesn't make sense to keep it for this one use case we can already support another way.

Nothing else uses any of this or is likely to use it, so I don't think it makes sense to leave it as dead code.

Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ccace46d62f4
part 1: Remove/replace the few remaining ipc/mscom uses in a11y code. r=nlapre
https://hg.mozilla.org/integration/autoland/rev/6376fec9febc
part 2: Remove ipc/mscom code only used by the old accessibility architecture based on content process COM proxies. r=bobowen
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: