1822005 - Consider to bypass client cert check for speculative connections created because of EarlyHint

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Kershaw Chang [:kershaw]]

Since we already create speculative connection for every http request anyway, maybe we can do the same for preconnect.

Comment 1

[Kershaw Chang [:kershaw]]

If I understand the reason why we added these two checks in bug 910207 correctly, we want to avoid the client certificate dialog popup unexpectedly.
For the early hint case in this bug, the speculative connection is triggered by receiving 103 response from server, so maybe it's fine to bypass these two checks.

Dana, what do you think? Is there anything I missed?

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

It might be, considering that the TLS handshake would have been completed at that point. That said, I would be wary of doing anything here until bug 1813618 is addressed by making client auth requests work with speculative connections.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1822005 - bypass client cert check for speculative connections created because of EarlyHint, r=manuel

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b043e4385379
bypass client cert check for speculative connections created because of EarlyHint, r=manuel,necko-reviewers

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b043e4385379