1822174 - push langpack tasks are failing CoT

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Uploading, defect)

Description

[[e-mail] (:bhearsum)]

This function (https://searchfox.org/mozilla-central/rev/af78418c4b5f2c8721d1a06486cf4cf0b33e1e8d/taskcluster/gecko_taskgraph/transforms/job/__init__.py#133) ends up setting the worker-implementation tag. This ends up giving us two worker implementation types in scriptworker (https://github.com/mozilla-releng/scriptworker/blob/b895fdd92b712958b8dba41d7fb8c4b162bc948b/src/scriptworker/cot/verify.py#L331), which ultimately causes us to hit this exception (https://github.com/mozilla-releng/scriptworker/blob/b895fdd92b712958b8dba41d7fb8c4b162bc948b/src/scriptworker/cot/verify.py#L375)

Comment 1

[[e-mail] (:bhearsum)]

Attachment: Bug 1822174: set worker implementation in push langpack transform to avoid tripping logic that adds extra tags, and breaks CoT verification r=#releng-reviewers!

This function (https://searchfox.org/mozilla-central/rev/af78418c4b5f2c8721d1a06486cf4cf0b33e1e8d/taskcluster/gecko_taskgraph/transforms/job/__init__.py#133) ends up setting the worker-implementation tag. This ends up giving us two worker implementation types in scriptworker (https://github.com/mozilla-releng/scriptworker/blob/b895fdd92b712958b8dba41d7fb8c4b162bc948b/src/scriptworker/cot/verify.py#L331), which ultimately causes us to hit this exception (https://github.com/mozilla-releng/scriptworker/blob/b895fdd92b712958b8dba41d7fb8c4b162bc948b/src/scriptworker/cot/verify.py#L375)

(It seems to me that set_implementation setting this tag will always cause this issue, so perhaps we need to remove that part of its code. At the very least, we should re-examine this...we support setting implementation and os in multiple places....which is very confusing.)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e25aef457b8d
set worker implementation in push langpack transform to avoid tripping logic that adds extra tags, and breaks CoT verification r=releng-reviewers,ahal

Comment 3

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a1558944c266

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e25aef457b8d