1822320 - URL bar dropdown intervention card divider has rounded ends

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Dana Lucaci, Desktop QA]

Attachment: Intervention card divider has rounded ends

Found in

• 112.0b1 (2023-03-13)

Affected versions

• 112.0b1 (2023-03-13)

Tested platforms

• macOS 12
• Ubuntu 22
• Windows 10.64

Affected platforms

• macOS 12
• Ubuntu 22
• Windows 10.64

Steps to reproduce

1. Open Firefox and focus the Address Bar.
2. Type "refresh firefox" (or anything else which triggers the intervention card) in the Address Bar.
3. Observe the "Intervention Card".

Expected result

• The intervention card is displayed with its divider ends straight.

Actual result

• The intervention card is displayed with its divider ends rounded.

Regression range

• First bad: 95efc81f5d0da6252772c8a344388de3df68001e

• Last good: 6b9c280f186bdf9338b45df9047465b80008c33d

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d26d38af0d2a11c2c469d614f38a291f36b5542b&tochange=95efc81f5d0da6252772c8a344388de3df68001e

• Potentially regressed by:
  Bug 1801297

Additional notes

• In Private browsing with "Light" theme enabled, the bottom divider line is not visible and straight.

Comment 1

[BugBot [:suhaib / :marco]]

:dlucaci, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1822320 - Remove border radius from tip rows. r=adw

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1801297

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/682b2afefee1
Remove border radius from tip rows. r=adw

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/682b2afefee1

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 9323035 [details]
Bug 1822320 - Remove border radius from tip rows. r=adw

Beta/Release Uplift Approval Request

• User impact if declined: cosmetic issue, see comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial CSS fix
• String changes made/needed: none
• Is Android affected?: No

Comment 7

[Dana Lucaci, Desktop QA]

I have verified the fix using Nightly 113.0a1 (20230316092607) on MacOS 12, Windows 10 and Ubuntu 22.

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9323035 [details]
Bug 1822320 - Remove border radius from tip rows. r=adw

Approved for 112.0b3

Comment 9

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a13682cddb94

Comment 10

[Dana Lucaci, Desktop QA]

I have verified the fix using Beta 112.0b3 (20230316192655) on MacOS 12, Windows 10 and Ubuntu 22.