Closed
Bug 1822378
Opened 2 years ago
Closed 2 years ago
Refactor OnboardingInteractor into its own file
Categories
(Fenix :: Onboarding, task, P3)
Tracking
(firefox113 verified)
VERIFIED
FIXED
113 Branch
Tracking | Status | |
---|---|---|
firefox113 | --- | verified |
People
(Reporter: gl, Assigned: gl)
References
Details
(Whiteboard: [fxdroid])
Attachments
(1 file)
We're looking to refactor the first run onboarding view out of the HomeFragment. This is part of small incremental refactoring that helps facilitate that process of decoupling the first run onboarding from the home screen.
We want to refactor OnboardingInteractor into its own file to decouple it from the Home screen. In doing so, we also want to make sure the functions inside of OnboardingInteractor are also limited to just the first run onboarding view.
Comment 1•2 years ago
|
||
Comment 2•2 years ago
|
||
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/35f46797aa5675af9c558f46211ca31dc656e768
[main] Bug 1822378 - Refactor OnboardingInteractor into its own file
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox113:
--- → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Comment 3•2 years ago
|
||
Verified on the latest Firefox for Android Nightly build 113.0a1 from 3/16 with the following devices:
- Oppo Find X3 Lite (Android 11),
- Lenovo tablet M10 (Android 10), and
- Samsung Galaxy Note 8 (Android 9).
On the onboarding, the covered areas were:
- changing the theme,
- changing the toolbar placement,
- tapping on "Sign in" in order to be redirected to the "Sync and save your data",
- changing the privacy protection,
- opening the "Privacy notice" SUMO page,
- interacting with the wallpaper prompt.
No issues were encountered, so I'll set this ticket as verified.
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Whiteboard: [fxdroid]
Updated•2 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•