Closed Bug 1822511 Opened 2 years ago Closed 28 days ago

[BE][www2.hm.com/nl_be] Form autofill/preview/clear are not applied properly in the eligible fields

Categories

(Toolkit :: Form Autofill, defect, P3)

Desktop
Windows 10
defect

Tracking

()

VERIFIED FIXED
136 Branch
Tracking Status
firefox-esr102 --- disabled
firefox111 --- disabled
firefox112 --- disabled
firefox113 --- disabled
firefox136 --- verified

People

(Reporter: epopescu, Assigned: theidkamp)

References

(Depends on 1 open bug, Blocks 1 open bug, )

Details

(Whiteboard: [fxcm-cc-compatibility])

Attachments

(7 files)

Found in

  • Firefox 111

Affected versions

  • Firefox 111

Tested platforms

  • Affected platforms: Windows 10

Preconditions

  • set pref extensions.formautofill.supportedCountries to IT,ES,PL,AT,BE in about:config
  • set pref browser.search.region to BE in about:config
  • use BE VPN
  • have several credit cards saved in about:preferences#privacy

Steps to reproduce

  1. Go to https://www2.hm.com/nl_be/index.html
  2. Add an item to cart and proceed to checkout
  3. Reach the payment page
  4. Click in either the Card Number or Expiration Date field

Expected result

  • Form autofill/preview/clear are applied in all the eligible fields.

Actual result

  1. First name and Last name are not previewed or autofilled.
  2. CC number and Expiry date are previewed, autofilled and cleared individually, but clicking in CC number field will autofill the Expiry date too.

Regression range

  • Not a regression because this feature is disabled by default.

Additional notes

Blocks: 1820733
Severity: -- → S3
Has STR: --- → yes
Depends on: 1755033

:epopescu, if you think that's a regression, could you try to find a regression range using for example mozregression?

Duplicate of this bug: 1822856
Depends on: 1815399
No longer depends on: 1755033
Priority: -- → P3
Attached video 2024-09-06_13h13_05.mp4

This issue is partially fixed. The card Number and expiry date fields that are in iframes and have the same origin are now fixed by bug 1906292 and work as expected. However the first name and last name fields are still not autofilled and not displaying the autocomplete dropdown even setting the extensions.formautofill.heuristics.autofillSameOriginWithTop to True. The first name and last name fields are part of the main frame.

Attached image 2024-09-06_13h19_51.png

about:autofill

Note. We also need to implement heuristic to update "given-name" and "family-name" to "cc-given-name" and "cc-family-name"

Depends on: 1923615
Attached video 2024-10-28_12h47_40.mp4

The autocomplete dropdown is still not displayed for the First name and Last name fields and they are also not autofilled if the autofill is triggered from the Card Number or Expiration date fields.

Attached file payload3.pdf
Attached file payload3.pdf
Whiteboard: [fxcm-cc-compatibility]
Assignee: nobody → theidkamp
Pushed by theidkamp@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47f3a708e7e7 Updating field parsing and update logic for credit card name field detection when name fields are in first position of the form. r=dimi

Backed out for causing bc failures @ browser_capture_name.js

TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/heuristics/browser_capture_name.js | Verify the name field - Got "John Doe", expected undefined
Flags: needinfo?(theidkamp)
Pushed by theidkamp@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a9830d5c7bb2 Updating field parsing and update logic for credit card name field detection when name fields are in first position of the form. r=dimi
Flags: needinfo?(theidkamp)

Backed out for causing bc failures @ browser_parse_street_address_fields.js

TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/heuristics/browser_parse_street_address_fields.js | [cc-given-name]: reason should be equal, expect regex-heuristic, got update-heuristic - "update-heuristic" == "regex-heuristic" -
Flags: needinfo?(theidkamp)
Pushed by theidkamp@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0aae5b7cd437 Updating field parsing and update logic for credit card name field detection when name fields are in first position of the form. r=dimi
Flags: needinfo?(theidkamp)
Status: NEW → RESOLVED
Closed: 28 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch

This issue can no longer be reproduced in the latest Nightly 136.0a1 on Windows 11. The autocomplete dropdown now displays correctly for the First name and Last name fields, and autofill functions as expected when triggered from the Card Number or Expiration Date fields. Marking this as Verified Fixed.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: