1822608 - about:memory diff should clear the PID for utility processes

Status: RESOLVED FIXED

(Toolkit :: about:memory, defect)

Description

[Andrew McCreight [:mccr8]]

In an about:memory report, the utility process shows up like this:
Utility (pid: 4216, sandboxingKind: 1)

For whatever reason, the about:memory diff fails to wipe the PID. It should be turned into
Utility (pid: NNN, sandboxingKind: 1)

like the other processes. The sandboxingKind looks like something that will be stable across different runs, so I think we want to keep it.

Presumably there's some regexp that needs to be adjusted in about:memory

Comment 1

[:gerard-majax]

sandboxingKind depends on the sandbox applied, so it might be different values

Comment 2

[Andrew McCreight [:mccr8]]

(In reply to Alexandre LISSY :gerard-majax from comment #1)

sandboxingKind depends on the sandbox applied, so it might be different values

Right, but my guess is that if you load a certain set of pages in two different browser sessions, the sandboxing kind would be stable across runs for a given process, while the PID won't be.

Comment 3

[:gerard-majax]

if it's the same set of pages, yes

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1822608 - Change aboutMemory pidRegex to match when there's a colon.

Utility processes have their pid like "pid: 12345", so change the regexp to match it.
This pidRegex is used to normalize PIDs in diffs. We need this change even if the format
gets changed so that it'll work on older versions.

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Bug 1822608 - Make PIDs for utility processes consistent with other processes.

Other processes print their pid like (pid 12345), so change utility processes to be consistent.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/446f0ae768fc
Change aboutMemory pidRegex to match when there's a colon. r=gerard-majax
https://hg.mozilla.org/integration/autoland/rev/5da77534d25a
Make PIDs for utility processes consistent with other processes. r=gerard-majax

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/446f0ae768fc
https://hg.mozilla.org/mozilla-central/rev/5da77534d25a