1822634 - Refactor tab counter code from HomeFragment into TabCounterView

Status: VERIFIED FIXED

(Firefox for Android :: Homepage, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

We're looking to refactor the first run onboarding view out of the HomeFragment. This is part of small incremental refactoring that helps facilitate that process of decoupling the first run onboarding from the home screen.

This is to refactor bits of logic for updating the tab counter into the TabCounterView - https://searchfox.org/mozilla-mobile/source/firefox-android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt#1032. This helps move more logic out of the HomeFragment into their respective view classes for better reusability and encapsulating all the functionality around a particular UI view.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1822634 - Refactor tab counter code from HomeFragment into TabCounterView (#1263)

Comment 2

[BMO Github Automation]

Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/fa0db437a53e7466cc3adaea70b989f9bfb0cb27
[main] Bug 1822634 - Refactor tab counter code from HomeFragment into TabCounterView

Comment 3

[Mira Lobontiu (Android QA)]

Verified on the latest Firefox nightly build 113.0a1 from 3/16 with the following devices:

• Oppo Find X3 Lite (Android 11),
• Lenovo tablet M10 (Android 10), and
• Samsung Galaxy Note 8 (Android 9).

The covered scenarios were:

• the tab counter displayed the correct number of opened tabs, both in normal and private mode,
• the tabs tray displays correctly the opened tabs, both in list view and grid view,
• the tab counter increases/decreases correctly when a tab is opened/closed.

Gabriel, is there anything else we should cover?

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Nope that is great. Thank you