1822665 - Multiple settings dialogs are trying to use a "Help" button that is no longer supported in MozDialog

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Hanna Jones [:hjones]]

Attachment: How the colors dialog looked before the help button code was removed

Previously MozDialog seems to have had support for specifying a "help" button that would link to a support article via a helpTopic attribute. That functionality was removed in this patch at the end of August. This seems to have been done because it appeared that the "help" buttons weren't used anywhere in Firefox, but there are actually six dialogs in preferences that are still have code related to help buttons.

This all seems like it can/should be cleaned up. Alternatively if we want to reintroduce the help buttons we should add tests for them too (we may replace the XUL dialog with an HTML equivalent sometime in the not too distant future and it would be great to have some testing safeguards in place).

Comment 1

[Hanna Jones [:hjones]]

Attachment: Colors dialog without help button

For context/comparison I've attached a screenshot of how the colors dialog looks now without the "Help" button.

Comment 2

[Javi Rueda :javirid]

Attachment: Bug 1822665 - Remove references to no longer supported MozDialog Help button. r?[e-mail]

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80dfbd0560ba
Remove references to no longer supported MozDialog Help button. r=settings-reviewers,[e-mail]

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/80dfbd0560ba