182273 - Bookmarks toolbar text drawn in black, not foreground colour

Status: VERIFIED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Alastair M. Robinson]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021029 Phoenix/0.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021029 Phoenix/0.4

Text on the Bookmarks Toolbar is hard to read if the window-manager's background
colour is dark, because it is drawn in black, instead of the foreground colour.

Reproducible: Always

Steps to Reproduce:
1. Using KDE2, set the background colour to something dark, and the foreground
colour to something light
2. Run Phoenix, and display the Bookmarks toolbar


Actual Results:  
Bookmark toolbar text is nearly invisible

Expected Results:  
Bookmark toolbar text should be drawn in foreground colour, not black.

Comment 1

[David Tenser [:djst]]

This is a theme issue. What theme are you using? If you're using Classic, this
bug report is probably useless since Classic will eventually be replaced with
another theme.

Comment 2

[Alastair M. Robinson]

This is Phoenix, out of the box, so I guess it's basically Orbit.

Comment 3

[Asa Dotzler [:asa]]

actually, this is probably a super easy fix until we get a new theme. In
browser.css we could just change color: black !important to menutext or
something like that. 

/* ::::: bookmark buttons ::::: */

toolbarbutton.bookmark-item {
  margin: 0;
  min-width: 0;
  max-width: 13em;
  padding: 2px 3px;
  color: black !important;
}

is where this is specified. I wonder why black was used instead of menutext.

Comment 4

[David Tenser [:djst]]

Changing OS to All.

Comment 5

[Alastair M. Robinson]

Commenting out both ocurrences of "color: black !important" fixes the problem
for me, so I'm happy :)

Does anyone know why a colour was specified here at all?

Comment 6

[alanjstr]

There are others.  I overrode them in my userChrome.css

.toolbarbutton-text,
toolbarbutton.bookmark-item, 
toolbarbutton:not([disabled="true"]):hover,
menubutton:not([disabled="true"]):hover,
toolbarbutton:not([disabled="true"]):hover:active,
menubutton:not([disabled="true"]):hover:active {
  color: -moz-dialogtext !important;
}

Comment 7

[Asa Dotzler [:asa]]

Is this still a problem in the new theme?

Comment 8

[Alastair M. Robinson]

I've just downloaded the latest nightly build, and at a quick glance the new
theme seems fine.

Comment 9

[David Tenser [:djst]]

Verifying.

Comment 10

[Simon Paquet [:sipaq]]

Taking QA Contact