1822748 - Typo in jit/moz.build causing build fail for riscv64 when JIT is enabled

Status: RESOLVED INVALID

(Core :: JavaScript Engine: JIT, defect)

Description

[JunYuan Tan]

Steps to reproduce:

This error will occur during mach build, when JIT for riscv64 is enabled (--enable-jit). This is due to the file in UNIFIED_SOURCES in js/src/jit/moz.build to be AssemblerMatInt.cpp.cpp, instead of AssemblerMatInt.cpp.

I can reproduce by following these steps:

1. Setup a native riscv64 machine/chroot (I am using chroot).
2. Clone the firefox-111 source code.
3. Add the following into the mozconfig file:

Build only the JS shell

ac_add_options --enable-application=js

Enable optimization for speed

ac_add_options --enable-optimize

Disable debug checks to better match a release build of Firefox.

ac_add_options --disable-debug

Use a separate objdir for optimized builds to allow easy

switching between optimized and debug builds while developing.

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-opt-@CONFIG_GUESS@

ac_add_options --target=riscv64-unknown-linux-gnu
ac_add_options --disable-bootstrap
ac_add_options --disable-rust-simd
ac_add_options --enable-jit

4. ./mach build and it will prompt the error during configure stage.
5. To fix it, change riscv64/AssemblerMatInt.cpp.cpp to riscv64/AssemblerMatInt.cpp in the js/src/jit/moz.build file. Then mach can proceed with the configure and build stage.

Actual results:

0:38.37 mozbuild.frontend.reader.SandboxValidationError:
0:38.37 ==============================
0:38.37 FATAL ERROR PROCESSING MOZBUILD FILE
0:38.37 ==============================
0:38.37 The error occurred while processing the following file or one of the files it includes:
0:38.37 /root/gecko-dev/js/src/jit/moz.build
0:38.38 The error occurred when validating the result of the execution. The reported error is:
0:38.38 File listed in UNIFIED_SOURCES does not exist: '/root/gecko-dev/js/src/jit/riscv64/AssemblerMatInt.cpp.cpp'

Expected results:

It should complete the configure process (Configure complete!) and continues to the build phase.

Comment 1

[JunYuan Tan]

Apologize for the formatting on the above comment, unable to edit it so let me edit the comment here:

Steps to reproduce:

This error will occur during mach build, when JIT for riscv64 is enabled (--enable-jit). This is due to the file in UNIFIED_SOURCES in js/src/jit/moz.build to be AssemblerMatInt.cpp.cpp, instead of AssemblerMatInt.cpp.

I can reproduce by following these steps:

1. Setup a native riscv64 machine/chroot (I am using chroot).

2. Clone the firefox-111 source code.

3. Add the following into the mozconfig file:
   '''
   ac_add_options --enable-application=js
   ac_add_options --enable-optimize
   ac_add_options --disable-debug
   ac_add_options --target=riscv64-unknown-linux-gnu
   ac_add_options --disable-bootstrap
   ac_add_options --disable-rust-simd
   ac_add_options --enable-jit
   '''

4. ./mach build and it will prompt the error during configure stage.

5. To fix it, change riscv64/AssemblerMatInt.cpp.cpp to riscv64/AssemblerMatInt.cpp in the js/src/jit/moz.build file. Then mach can proceed with the configure and build stage.

Actual results:

0:38.37 mozbuild.frontend.reader.SandboxValidationError:
0:38.37 ==============================
0:38.37 FATAL ERROR PROCESSING MOZBUILD FILE
0:38.37 ==============================
0:38.37 The error occurred while processing the following file or one of the files it includes:
0:38.37 /root/gecko-dev/js/src/jit/moz.build
0:38.38 The error occurred when validating the result of the execution. The reported error is:
0:38.38 File listed in UNIFIED_SOURCES does not exist: '/root/gecko-dev/js/src/jit/riscv64/AssemblerMatInt.cpp.cpp'

Expected results:

It should complete the configure process (Configure complete!) and continues to the build phase.

Comment 2

[JunYuan Tan]

Attachment: Bug 1822748 - Fix typo on jit/moz.build. r=jandem

Comment 3

[JunYuan Tan]

Closing this as this is similar to bug 1822747