1822759 - Permission checkboxes overlap in Page Info panel

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Kestrel]

Attachment: Overlapping permissions

STR:

1. Open the Page Info panel (Ctrl+I) and select the Permissions tab.
2. Shrink the window if necessary.

The "Use Default" checkbox overlaps with the following permission name.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=40a93120bacc5957b5da058bfcab903a2a184adf&tochange=aa9a63adab87ae4bdd4841965e6c26db12584f0c

Regressed by Bug 1822131.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1822131, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1822759 - Unify pageInfo.css. r=Gijs,dao

Except the header styles, most of the other styles are identical.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1822759 - Use min-height: auto for permissions in pageInfo window. r=dao,Gijs

That gets the right behavior even with flex-shrink: 1. An alternative
would be to also set flex-shrink: 0, but I don't see how this min-height
is useful so may as well remove code. Either way.

Depends on D172767

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86f4f0a9ce68
Unify pageInfo.css. r=dao
https://hg.mozilla.org/integration/autoland/rev/aa5bf955a23c
Use min-height: auto for permissions in pageInfo window. r=dao

Comment 5

[Cristina Horotan [:chorotan]]

Backed out 2 changesets (Bug 1822759) for causing build bustage at pageInfo.css

Backout: https://hg.mozilla.org/integration/autoland/rev/9b37d1712fc3a1fd12079c9979b52cc7a9c9c67d

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=aa5bf955a23c5db2945af2b27d663edeec3cbe63&selectedTaskRun=RHBeIbhJS6adUAK3q4dtOg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=409476580&repo=autoland&lineNumber=84913

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f197e3949eb0
Unify pageInfo.css. r=dao
https://hg.mozilla.org/integration/autoland/rev/c3037ba20d8b
Use min-height: auto for permissions in pageInfo window. r=dao

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b6fc3c7dba2
Fix a minor typo on the previous patches.

Comment 8

[Marian-Vasile Laza]

Backed out 3 changesets (Bug 1822759) for bc failures on browser_parsable_css.js.
Backout link
Push with failures <--> bc3
Failure Log

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1822759 - Fix browser_parsable_css.js to account for @media not (-moz-platform...). r=Gijs,dao,mconley

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/320fbe2d69f2
Fix browser_parsable_css.js to account for @media not (-moz-platform...). r=Gijs

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a05d0e98261c
Unify pageInfo.css. r=dao
https://hg.mozilla.org/integration/autoland/rev/1371c18ce24f
Use min-height: auto for permissions in pageInfo window. r=dao

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/320fbe2d69f2
https://hg.mozilla.org/mozilla-central/rev/a05d0e98261c
https://hg.mozilla.org/mozilla-central/rev/1371c18ce24f