1822867 - Over-aggressive warning for "ClientWaitSync must return TIMEOUT_EXPIRED until..."

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Kelsey Gilbert [:jgilbert]]

The warning is accurate, but it's likely common for apps to be constructed such that they query one or a few times before returning to the event loop. Rather than asking them to refactor or workaround to avoid this (in this case merely pendantic) warning, we should just only warn if it looks like someone's spin-locking.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1822867 - Only generate "ClientWaitSync not ready yet" warning after 100th time.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jgilbert, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/828b44a3c32b
Only generate "ClientWaitSync not ready yet" warning after 100th time. r=gfx-reviewers,lsalzman

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/828b44a3c32b