1822918 - Weather fetch can take too long to start after wake or coming online

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Currently the weather suggestion is fetched on a 30-minute timer. The timer stops ticking while the computer is asleep, so if you put your computer to sleep at night and wake it in the morning, it can take up to 30 minutes for the suggestion from the previous night to be refreshed. Similarly, if you're offline and you come online, it can take the full refresh period for the suggestion to be fetched again.

Sync faces this same problem, so we can take inspiration from it. It listens for the following observer service notifications and schedules new syncs as necessary:

• wake_notification
• network:link-status-changed - This is sent when the user's network status changes
• network:offline-status-changed - This is sent when the user toggles the "Work Offline" pref
• captive-portal-login-success

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1822918 - Fetch the weather suggestion after wake and coming online.

This listens for some observer service notifications so we can re-fetch the
weather suggestion after wake and coming online, without having to wait for the
timer to fire. Please see the bug for background.

I changed the interval (repeating timer) to a timeout (non-repeating timer)
since the timer needs to be recreated on wake if the wake happens before the
start of the next fetch period.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2144589764eb
Fetch the weather suggestion after wake and coming online. r=daisuke

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2144589764eb