Open Bug 1823311 Opened 2 years ago Updated 2 years ago

X button to close tab disappears

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect

Tracking

()

Status:
UNCONFIRMED

People

(Reporter: blakewolf, Unassigned, NeedInfo)

Details

Attachments

(2 files)

2023-03-26 20-53-00.mp4
4.20 MB, application/octet-stream
Details
FF.png
1.47 MB, image/png
Details

Steps to reproduce:

  1. Open a new tab
  2. On a second tab, view a video fullscreen. Then close the fullscreen

Actual results:

The X button to close a tab disappears

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Tabbed Browser

Hello,
I tried unsuccessfully to reproduce the issue on Win 10 and MacOs12 in Fx Nightly 113.0a1 (2023-03-24) and in the 2022-10-09 and 2022-10-10 Fx builds using mozregression following these steps:

  1. Launch Firefox.
  2. Open a second tab.
  3. Go to https://www.youtube.com/
  4. Open a random video in full screen.
  5. Exit fullscreen.

Actual results: X button is present on both tabs.

Could you please provide some more details in order to further investigat this issue?

  1. On what OS are you experiencing this issue?
  2. Can you give an example of a website for which this issue occurs?
  3. How long should the full screen be opened?
  4. Does this issue happen with a new profile?
    Here is a link on how to create one: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles
  5. Does this issue happen in the latest nightly?
    Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/
  6. Do you have any addons installed, if so can you list them?
Flags: needinfo?(blakewolf)

(In reply to nicoleta.sibisan from comment #3)

Hello,
I tried unsuccessfully to reproduce the issue on Win 10 and MacOs12 in Fx Nightly 113.0a1 (2023-03-24) and in the 2022-10-09 and 2022-10-10 Fx builds using mozregression following these steps:

  1. Launch Firefox.
  2. Open a second tab.
  3. Go to https://www.youtube.com/
  4. Open a random video in full screen.
  5. Exit fullscreen.

Actual results: X button is present on both tabs.

Could you please provide some more details in order to further investigat this issue?

  1. On what OS are you experiencing this issue?
  2. Can you give an example of a website for which this issue occurs?
  3. How long should the full screen be opened?
  4. Does this issue happen with a new profile?
    Here is a link on how to create one: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles
  5. Does this issue happen in the latest nightly?
    Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/
  6. Do you have any addons installed, if so can you list them?

Sorry for the delay, I was not able to reliably reproduce the issue this time to maybe it is dependent on the site's video player.

  1. Windows 10 (19045)
  2. This time, I was on the site https://streameast.top, however, videos aren't always live or active.
  3. Fullscreen only needs to be initiated so it should only take a second or two.
  4. Issue did reproduce in a new profile.
    5./6. I can reproduce this on the latest nightly. On my profile, my extensions are Ublock Origin, Forecastfox, and Rally.
Flags: needinfo?(blakewolf)

Latest nightly, new profile

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dao+bmo)

I tried to reproduce your issue without any success.
Would you be so kind as to update the browser to the latest version and confirm if this issue is still happening?
Thank you.

Flags: needinfo?(blakewolf)

I’m not sure if this is completely related but I am experiencing a similar issue on the current Nightly (119.0a1 (2023-08-30) (64-bit)).

To reproduce:

  1. Open private window (Ctrl+Shift+P)
  2. Create new tabs using Ctrl+T
  3. Keep creating new tabs
  4. After a particular number of tabs (11 for me on full screen 1920x1080), the X button disappears on the tabs.

Adding new tabs after that will keep the X button invisible. Once you start closing tabs again, it will eventually appear again.

It seems that this is related to the tab width, maybe the X button overflows once the tab width goes below a certain size.

(In reply to Patrick Westerhoff from comment #8)

I’m not sure if this is completely related but I am experiencing a similar issue on the current Nightly (119.0a1 (2023-08-30) (64-bit)).

that's a recent regression tracked in bug 1850649

(In reply to Marco Bonardo [:mak] (away 11-21 Aug) from comment #9)

that's a recent regression tracked in bug 1850649

Ah, thank you, I wasn’t able to find this in my search! :)

I just wanted to say that this just happened to me. My browser updated to Fx 119 Nightly and the "X" on the tabs of one of my windows disappeared.

I figured out why it was happening on one window but not the other. Similarly to Patrick's comment above, it seems to be related to the number of tabs opened. When I have many of them open, the "x" disappears. If I close tabs, it reappears. It's as if the responsive design of the tabs hides the X when the browser judges that there are too many tabs open.

Hope this helps

(In reply to Ardelean Oana, Desktop QA from comment #7)

I tried to reproduce your issue without any success.
Would you be so kind as to update the browser to the latest version and confirm if this issue is still happening?
Thank you.

Yes, I'm still able to reproduce this issue on the latest nightly.

Flags: needinfo?(blakewolf)

Unfortunately latest Nightly doesn't matter because there was a recent regression making the button disappear for everyone for a few builds, please retest starting from today on.

The bug as-is is not actionable because the steps to reproduce are not consistent (QA was unable to reproduce) and the mozregression in comment 1 seems unlikely, since it's touching nsIEditor. I wonder if the mozregression was confused by the fact the issue is intermittent on your side.

Anyway, please retest with a Nightly build from today on.

Hy Blake, could you please follow the instructions from Comment 13 so we can know if the issue is indeed fixed?

Flags: needinfo?(blakewolf)
Attached image FF.png —

Can confirm that in the latest nightly the X button to close a tab still disappears.

Flags: needinfo?(blakewolf)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: