1823326 - Refactor JSON parser to decouple allocation

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

The current JSON parser is tightly coupled with JSContext and JS::Value/JSObject handling.

To achieve JSContext-free parsing, the parser needs to be decoupled from the allocation of the runtime objects.

We could use a template-based approach similar to FullParseHandler and SyntaxParseHandler,
so that the abstraction itself doesn't affect the performance.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1823326 - Part 1: Move tokenization methods to the top of the file. r?bthrall!

The later patch will add JSONTokenizer class to store those methods.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1823326 - Part 2: Move token enum out of JSONParserBase. r?bthrall!

JSONToken is going to be used across tokenizer and parser classes.

Depends on D174559

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1823326 - Part 3: Add JSONTokenizer. r?bthrall!

Depends on D174560

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1823326 - Part 4: Move JSONStringType out of JSONTokenizer. r?bthrall!

Depends on D174561

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1823326 - Part 5: Move string and number value handling into JSON parser. r?bthrall!

Allocation part is going to be moved to handler class later.

Depends on D174562

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1823326 - Part 6: Move JSONParserState out of JSONParserBase. r?bthrall!

Depends on D174563

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1823326 - Part 7: Split JSONParser into handler and parser. r?bthrall!

JSONFullParseHandler and JSONFullParseHandlerAnyChar corresponds to
FullParseHandler in frontend.
These classes handle allocation and runtime-specific things.

Depends on D174564

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1823326 - Part 8: Templatize JSONTokenizer. r?bthrall!

In order to add syntax-parser later, make tokenizer accept template parameter.

Depends on D174565

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1823326 - Part 9: Wrap JSStringBuilder to support syntax parser. r?bthrall!

Syntax parser does not need string allocation.

Depends on D174566

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1823326 - Part 10: Reorder JSONFullParseHandlerAnyChar declaration. r?bthrall!

Depends on D174567

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1823326 - Part 11: Add JSONPerHandlerParser. r?bthrall!

To support handler for syntax parser, make the parser templatized for handler.

Depends on D174568

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20e31adf0627
Part 1: Move tokenization methods to the top of the file. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/927bc0c48c6d
Part 2: Move token enum out of JSONParserBase. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/f21226706008
Part 3: Add JSONTokenizer. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/07f59d899003
Part 4: Move JSONStringType out of JSONTokenizer. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/8dd802c54fe3
Part 5: Move string and number value handling into JSON parser. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/bbfe63774429
Part 6: Move JSONParserState out of JSONParserBase. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/cfa47a2d2829
Part 7: Split JSONParser into handler and parser. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/363ef3379606
Part 8: Templatize JSONTokenizer. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/a5dd696c30bd
Part 9: Wrap JSStringBuilder to support syntax parser. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/630daf6fe40f
Part 10: Reorder JSONFullParseHandlerAnyChar declaration. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/8f20eba2a842
Part 11: Add JSONPerHandlerParser. r=bthrall

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/20e31adf0627
https://hg.mozilla.org/mozilla-central/rev/927bc0c48c6d
https://hg.mozilla.org/mozilla-central/rev/f21226706008
https://hg.mozilla.org/mozilla-central/rev/07f59d899003
https://hg.mozilla.org/mozilla-central/rev/8dd802c54fe3
https://hg.mozilla.org/mozilla-central/rev/bbfe63774429
https://hg.mozilla.org/mozilla-central/rev/cfa47a2d2829
https://hg.mozilla.org/mozilla-central/rev/363ef3379606
https://hg.mozilla.org/mozilla-central/rev/a5dd696c30bd
https://hg.mozilla.org/mozilla-central/rev/630daf6fe40f
https://hg.mozilla.org/mozilla-central/rev/8f20eba2a842