182341 - crash:bring up prof. mgr window, click x in top rt hand crnr and it crashes: [@ SearchTable cefa3818]

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect)

Description

[grylchan]

using commercial trunk
2002-11-27-08-trunk/ on Xp(Sp1).

I brought up the profile mgr via windows: Start|Mozilla|Profile Mgr
I then decided to close the window via the 'window close widget' aka
the x in the top right hand corner of profile mgr. It then crashed.

steps
1.bring up profile mgr
2.Kill the window via clicking X in right hand top corner
result: crash
expected: to not crash

Talback ids: 14465501, 14465329

stack trace:
SearchTable [c:/builds/seamonkey/mozilla/xpcom/ds/pldhash.c, line 350]
PL_DHashTableOperate [c:/builds/seamonkey/mozilla/xpcom/ds/pldhash.c, line 543]
AtomImpl::~AtomImpl [c:/builds/seamonkey/mozilla/xpcom/ds/nsAtomTable.cpp, line 
173]
AtomImpl::`scalar deleting destructor'
AtomImpl::Release [c:/builds/seamonkey/mozilla/xpcom/ds/nsAtomTable.cpp, line 
181]
nsProfileDirServiceProvider::~nsProfileDirServiceProvider 
[c:/builds/seamonkey/mozilla/profile/dirserviceprovider/src/nsProfileDirServiceP
rovider.cpp, line 97]
nsProfileDirServiceProvider::`scalar deleting destructor'
nsProfileDirServiceProvider::Release 
[c:/builds/seamonkey/mozilla/profile/dirserviceprovider/src/nsProfileDirServiceP
rovider.cpp, line 163]
nsCOMPtr_base::~nsCOMPtr_base 
[c:/builds/seamonkey/mozilla/xpcom/glue/nsCOMPtr.cpp, line 65]
_DllMainCRTStartup@12()
ntdll.dll + 0x2572a (0x77f7572a)
ntdll.dll + 0xe52d (0x77f5e52d)
kernel32.dll + 0x198cc (0x77e798cc)
kernel32.dll + 0x1990f (0x77e7990f)
msvcrt.dll + 0x279c8 (0x77c379c8)
kernel32.dll + 0x214c7 (0x77e814c7)

Comment 1

[Alec Flett]

ugh, this is why static nsCOMPtrs are verboten. who is holding a static ref here?

Comment 2

[Conrad Carlen (not reading bugmail)]

Attachment: patch

Comment 3

[racham]

Comment on attachment 107918 [details] [diff] [review]
patch

r=bhuvan

Comment 4

[Alec Flett]

Comment on attachment 107918 [details] [diff] [review]
patch

sr=alecf

Comment 5

[Sander]

*** Bug 184706 has been marked as a duplicate of this bug. ***

Comment 6

[Conrad Carlen (not reading bugmail)]

Sorry, I thought I had checked this in long ago. Setting milestone so it doesn't
get lost again.

Comment 7

[Conrad Carlen (not reading bugmail)]

Checked in.

Comment 8

[Grace Bush]

mozilla and commercial 3/11 builds tested