1823417 - Webtransport session close issues

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Kershaw Chang [:kershaw]]

We've found some issues when dealing with closing a webtransport session.

1. The log below shows that another http3 session can be affected by a one that receives a NS_ERROR_NET_HTTP3_PROTOCOL_ERROR.
   Since we only support webtransport with Http/3 for now, we can't exclude the failed origin.

2023-03-17 01:47:04.297472 UTC - [Parent 26108: Socket Thread]: V/nsHttp Http3Session::ProcessEvents - ConnectionClosed
2023-03-17 01:47:04.297472 UTC - [Parent 26108: Socket Thread]: V/nsHttp Http3Session::ProcessEvents - ConnectionClosed error=804b0054
2023-03-17 01:47:04.297473 UTC - [Parent 26108: Socket Thread]: V/nsHttp HttpConnectionUDP::CloseTransaction[this=2b86e5f30 trans=2dca99c00 reason=804b0054]
2023-03-17 01:47:04.297474 UTC - [Parent 26108: Socket Thread]: V/nsHttp Http3Session::Close [this=2dca99c00]
2023-03-17 01:47:04.297475 UTC - [Parent 26108: Socket Thread]: V/nsHttp nsHttpConnectionMgr::ReclaimConnection [conn=2b86e5f30]
2023-03-17 01:47:04.297476 UTC - [Parent 26108: Socket Thread]: I/nsHttp Http3Session::~Http3Session 2dca99c00
2023-03-17 01:47:04.297478 UTC - [Parent 26108: Socket Thread]: D/nsHttp nsHttpHandler::ExcludeHttp2OrHttp3Internal ci=.SA......W[tlsflags0x00000000]web-platform.test:11000 {NPN-TOKEN h3}
2023-03-17 01:47:04.297480 UTC - [Parent 26108: Socket Thread]: V/nsHttp nsHttpConnectionMgr::ExcludeHttp3 exclude ci .SA......W[tlsflags0x00000000]web-platform.test:11000 {NPN-TOKEN h3}
2023-03-17 01:47:04.297483 UTC - [Parent 26108: Socket Thread]: V/nsHttp HttpConnectionUDP::DontReuse 2db3890c0 http3session=2dca9a200
2023-03-17 01:47:04.297484 UTC - [Parent 26108: Socket Thread]: I/nsHttp Http3Session::DontReuse 2dca9a200

2. This Close seems not correct, since we could close the http3 session while mWebTransportSessions or mWebTransportStreams is not empty.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1823417 - Don't exclude Http3 origin for WebTransport, r=jesup

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b8c7dcc2815
Don't exclude Http3 origin for WebTransport, r=jesup,necko-reviewers

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4b8c7dcc2815