Closed
Bug 1823455
Opened 1 year ago
Closed 1 year ago
Consider merging nsHTMLScrollFrame and ScrollFrameHelper.
Categories
(Core :: Layout: Scrolling and Overflow, task)
Core
Layout: Scrolling and Overflow
Tracking
()
RESOLVED
FIXED
113 Branch
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
After bug 1600542 seems this ought to be possible. While at it we might want to rename nsHTMLScrollFrame
to just mozilla::ScrollFrame
or so.
Comment 1•1 year ago
|
||
nsHTMLScrollFrame
have a lot of methods delegating to ScrollFrameHelper
. I cannot wait to see them simplified.
While at it we might want to rename nsHTMLScrollFrame to just mozilla::ScrollFrame or so.
+1 for the rename in a separate patch, and rename nsGfxScrollFrame.h/cpp
to ScrollFrame.h/cpp
.
Assignee | ||
Comment 2•1 year ago
|
||
Now there's only one of these this is possible.
I want to do this before making scrollbars non-XUL.
Renaming to mozilla::ScrollFrame is left for a follow-up bug.
Updated•1 year ago
|
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b07b4673205 Merge ScrollFrameHelper and nsHTMLScrollFrame. r=layout-reviewers,TYLin
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/660a12353016 Add a missing include to fix hybrid builds.
Comment 5•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0b07b4673205
https://hg.mozilla.org/mozilla-central/rev/660a12353016
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•