1823466 - [wpt-sync] Sync PR 39086 - Revert "[anchor-position] Make `anchor` attribute work for non-popovers"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39086 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39086
Details from upstream follow.

Xiaocheng Hu <[e-mail]> wrote:

Revert "[anchor-position] Make anchor attribute work for non-popovers"

This reverts commit 4abd0d04120561b80ad2e6dd398651d7e909463f.

Reason for revert: Caused a lot of performance regressions.

Original change's description:

[anchor-position] Make anchor attribute work for non-popovers

This patch reimplements how we mark elements that are implicit anchors.
Previously it was only marked for popover element's implicit anchors,
and now it works for all implicit anchors. This is done by a new class
AnchorElementObserver that observes all possible changes in implicit
anchor and replaces the old PopoverAnchorObserver.

This patch also reveals two existing issues:

1. Element::GetElementAttribute() may return non-null result even if
   the element is out of tree scope. As fixing the bug is out of the
   scope here, this patch just works around it. crbug.com/1425215 was
   filed.
2. popover-anchor-idl-property.html has some bugs that made it pass
   previously. This patch fixes those bugs.

Fixed: 1417346
Change-Id: I798977ab1ed7df0c528b7eb98c64fc04476e6106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4338487
Commit-Queue: Xiaocheng Hu \<[e-mail]>
Reviewed-by: Mason Freed \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1118933}

Bug: 1425610, 1425635, 1425650
Change-Id: I50a650f011e097c48c0efd110cf765d0df5835e4

Reviewed-on: https://chromium-review.googlesource.com/4353985
WPT-Export-Revision: ece230b997d7f17c8782e2657d651310731ef2f2

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=acb073a03499d622f12c4c7b1c58b4147a5b2444

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=089625775ff14ee585fbbd0ba7f210b2b8a77a77

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
FAIL: 3

Chrome

OK : 1
PASS: 3

Safari

OK : 1
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/popovers/popover-anchor-idl-property.html [wpt.fyi]
  • popover anchorElement IDL property returns the anchor element: FAIL (Chrome: PASS, Safari: FAIL)
  • popover anchorElement is settable: FAIL (Chrome: PASS, Safari: FAIL)
  • anchorElement affects anchor positioning: FAIL (Chrome: PASS, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b090755f9428
[wpt PR 39086] - Revert "[anchor-position] Make `anchor` attribute work for non-popovers", a=testonly

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b090755f9428