1823543 - Add telemetry to distinguish trending results

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1823543 - Add telemetry to distinguish trending results. r=adw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1c6aec6cf19
Add telemetry to distinguish trending results. r=adw

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f1c6aec6cf19

Comment 4

[Adrian Florinescu [:aflorinescu]]

Dale, could you please review the following and confirm/clarify where needed:

1. scalar telemetry: urlbar.picked.trending - records the position the trending was picked from - since the trending list is variable, not sure why it records the position out of which the trending was selected. Also, shouldn't we diferentiate betwen addressbar pick and addressbar searchmode pick?
2. glean telemetry: trending_search groups, trending_search result, trending_search selected_result(where applicable), pretty clear here.
3. how browser.urlbar.trending.maxResultsNoSearchMode is supposed to function in relationship with topsites and maxRichResults: e.g.: if I have browser.urlbar.trending.maxResultsNoSearchMode set to 9, should it show 9 and 1 topsite, or there is a different logic here? I would've expected to be able to push out all topsites out of the addressbar and replace it with trending.

Comment 5

[Dale Harvey (:daleharvey)]

Hi Adrian

1. This is mostly to be consistent with the rest of the urlbar.picked scalars, its also useful information for data science as far as I understand to understsand which positions users are picking results at and how different result type effect that.

2. maxRichResults will override any trending.maxResults, so if we get 10 trending results, then cull that to 8 with trending.maxResults, then maxRichResults is 4 it will reduce it down to 4. How those results are composed is down to the Muxer

Comment 6

[Adrian Florinescu [:aflorinescu]]

Tiding up things, this issue should've been marked as verified a while back, since the questions here have been also discussed offline and covered extensively in the GTP feature test runs.