1823545 - SVG attribute handling is a bit allocator heavy

Status: RESOLVED FIXED

(Core :: SVG, enhancement, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

https://speedometer-preview.netlify.app/interactiverunner
React-Stockcharts-SVG

Bug 1823397 fixed one case, but there are others.

https://searchfox.org/mozilla-central/rev/d2786d9a6af7507bc3443023f0495b36b7e84c2d/dom/svg/SVGElement.cpp#334-335
We seem to delete and then soon recreate a DeclarationBlock.

https://searchfox.org/mozilla-central/rev/d2786d9a6af7507bc3443023f0495b36b7e84c2d/dom/svg/SVGElement.cpp#1147,1151,1162
URLExtraData lives usually (always?) just as long as the stack allocated MappedAttrParser.
Could also it be allocated from the stack? Or if it needs to stay alive longer in some cases, could such heap allocation happen lazily?

Comment 1

[Brian Grinstead [:bgrins]]

FYI to save some clicks on the runner you can preselect the suite with https://speedometer-preview.netlify.app/interactiverunner?suite=React-Stockcharts-SVG. Or to if you want 0 clicks you can do https://speedometer-preview.netlify.app/?suite=React-Stockcharts-SVG&developerMode&startAutomatically=true#running

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1823545 - Reuse declaration block with SVG presentation attributes. r=smaug

Ideally we'd only update the attributes that actually changed. That's a
bit more work I can try to look into, but this and bug 1823686 should
improve things here.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93ff6361a0f3
Reuse declaration block with SVG presentation attributes. r=smaug

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/93ff6361a0f3