1823760 - Autocomplete popup content cropped

Status: VERIFIED FIXED

(Toolkit :: Autocomplete, defect, P2)

Description

[Issam Mani [:issammani]]

Attachment: current autocomplete popup content cropped

Autocomplete popup not displayed properly after 1823515

Comment 1

[Issam Mani [:issammani]]

Attachment: Bug 1823760 - Allow panel content to stretch. r=#credential-management-reviewers,dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28e1f051606d
Allow panel content to stretch. r=dao,credential-management-reviewers,sgalich

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/28e1f051606d

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for causing Bug 1824280.

backout: https://hg.mozilla.org/integration/autoland/rev/81f241442179c352497946dc557dcc61e9e030da

Comment 5

[Emilio Cobos Álvarez (:emilio)]

This was fixed in other ways (bug 1823764). There's one remaining issue (the fixed width of the two-line-item thing, which should be a straight-forward removal now). The patch in bug 1824280 does that, but at that point maybe it should be attached to this bug instead?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

(I asked sheriffs to back out since bug 1824280 already included the back out anyways, hopefully that's fine for you Issam :))

Comment 7

[Issam Mani [:issammani]]

The patch in bug 1824280 does that, but at that point maybe it should be attached to this bug instead?

Yes that makes sense to me ! Will re-attach to this one.

(I asked sheriffs to back out since bug 1824280 already included the back out anyways, hopefully that's fine for you Issam :))

Sounds good :)

Comment 8

[Issam Mani [:issammani]]

Attachment: Bug 1823760 - Size autocomplete richlistitem properly. r=sgalich!

• Revert changes made to min-width and width in [[ https://phabricator.services.mozilla.com/D173182 | D17318 ]]. This caused the search bar not wrapping regression.

  • Localize sizing to MozAutocompleteTwoLineRichlistitem for password manager popup.

  • Searhbar engine is now wrapping as expected:

{F4562995}

• Password manager popup is sized properly:
  {F4563005}
  {F4563006}
  {F4563007}

Comment 9

[Sandor Molnar[:smolnar]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/81f241442179

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7a33492220f
Size autocomplete richlistitem properly. r=desktop-theme-reviewers,credential-management-reviewers,dao,sgalich

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a7a33492220f

Comment 12

[Anca Soncutean, Desktop QA]

I can't reproduce it on my side. Issam Mani, it would be possible for you to provide me with the sample form that was used to demonstrate the problem, so that I can confirm the fix on Fx 113? Thank you!

Comment 13

[Issam Mani [:issammani]]

Hi Anca, I was able to reproduce this on Nightly 113.0a1 (2023-03-19). This is the website I used for testing: https://mozilla.github.io/form-fill-examples/password_manager/login_and_pw_change_forms.html

Comment 14

[Anca Soncutean, Desktop QA]

[:issammani] from comment #13)

Hi Anca, I was able to reproduce this on Nightly 113.0a1 (2023-03-19). This is the website I used for testing: https://mozilla.github.io/form-fill-examples/password_manager/login_and_pw_change_forms.html

Thank you for your prompt reply!
Reproduced with Fx 113.0a1 (2023-03-19) on Windows 10.
Verified fixed with Fx 114.0a11 (2023-05-08) and Fx 113.0 on Windows 10 and Ubuntu 22.