1823884 - ./mach jit-test no longer shows the progress bar

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

In ProgressBar.conservative_isatty we try to import android and if that succeeds we think we're on Android and return false. Bug 1821221 added build/android/libgcc.a so now the import no longer throws an exception and we don't show the progress bar anymore.

There's a similar import python in lib/jittests.py

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1821221

:glandium, since you are the author of the regressor, bug 1821221, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Jan de Mooij [:jandem]]

It's not clear to me if we still need this workaround for Android/adb from 13 years ago (bug 600639). We use a different remote runner for that now IIUC.

Comment 3

[Ted Campbell [:tcampbell]]

The mach jit-test --remote setup for running jsshell tests on physical devices runs the progress bar on host machine and just a lightweight shell script on the device itself, so we do not need any special handling to continue supporting it and things will be fine there if we remove the 'import android' stuff.

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1823884 - Fix jit-test progress bar by removing an old workaround for Android. r?tcampbell!

Adding the build/android/ directory in bug 1821221 broke the progress bar, because
the import android hack to check for Android started to match other platforms too.

Because we now use a different remote runner and render the progress bar on the host
machine, we want to try removing those old workarounds.

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1823884 - Remove unused avoid_stdio flag. r?tcampbell!

This option is no longer hooked up to anything.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84683bdb8e18
Remove unused avoid_stdio flag. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ff83ef557f89
Fix jit-test progress bar by removing an old workaround for Android. r=tcampbell

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/84683bdb8e18
https://hg.mozilla.org/mozilla-central/rev/ff83ef557f89