The translations language ID has a race condition with construction
Categories
(Firefox :: Translations, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: gregtatum, Assigned: gregtatum)
References
Details
Attachments
(2 files)
The identify language has a race condition where the identifyLanguage call is not waiting on constructor, which leads to errors on the first detection.
|
Assignee | |
Comment 1•1 year ago
|
||
Depends on D171616
|
|
Assignee | |
Comment 2•1 year ago
|
||
The tests were always outputing language id errors, since it couldn't
start the engine. This makes it so that tests always have a mock of some
kind.
Depends on D173288
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a62d77bfac0b Fix race condition with language id engine creation; r=nordzilla https://hg.mozilla.org/integration/autoland/rev/841d7b8b856b Drive by fix transient about:translations test errors; r=nordzilla
|
||
Comment 4•1 year ago
|
||
Backed out for causing failures at browser_full_page.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/824c14ab68396152de37a562f09df8ce71f924bf
Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=457474e589d4544345a1f55d4343a4b70ded1d1e&selectedTaskRun=Hrqjdo8ESFSvywMOFoyoyw.0
Failure log: https://treeherder.mozilla.org/logviewer?job_id=410034037&repo=autoland&lineNumber=11999
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d3bd9407130 Fix race condition with language id engine creation; r=nordzilla https://hg.mozilla.org/integration/autoland/rev/e8e2efcca2e1 Drive by fix transient about:translations test errors; r=nordzilla
|
||
Comment 6•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2d3bd9407130
https://hg.mozilla.org/mozilla-central/rev/e8e2efcca2e1
Description
•