1823949 - New Shortcuts are not added to the Top Sites section if previously dismissing all the non-sponsored tiles

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

[Affected versions]:

• Firefox Nightly 113.0a1 - Build ID: 20230322094136

[Affected Platforms]:

• Windows 10 x64
• macOS 12.4
• Linux Ubuntu 20.04 x64

[Prerequisites]:

• Have a VPN client connected to a US server (for people located outside the US).

[Steps to reproduce]:

1. Open the browser from the prerequisites.
2. Open a new tab.
3. Dismiss all the non-sponsored tiles.
4. Hover any of the empty tiles, EXCEPT the one next to the sponsored one.
5. Click the “Edit this site” button.
6. Add a site title and a valid URL on the “New Shortcut” window.
7. Click the “Add” button and observe what happens next.

[Expected result]:

• A new shortcut is created with the details entered in step 6.

[Actual result]:

• Nothing happens, the tile remains empty.

[Regression window]:

• This result represents the best changelog range we managed to bisect using Mozregression.
• Last good revision: 908a298d2fdd967fda1fdcd09a017952c46c4e7a
• First bad revision: 77bb7e3dc44cc54cf535e81ab2269c2a094afc0e
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=908a298d2fdd967fda1fdcd09a017952c46c4e7a&tochange=77bb7e3dc44cc54cf535e81ab2269c2a094afc0e
• From the pushlog above, it seems that Bug 1822604 is the one that caused this regression.

[Notes]:

• The issue is not reproducible using the empty tile next to the Sponsored one.
• After doing the STR above, I noticed that dismissing the Sponsored tiles as well will make the new shortcut be displayed. Also, the 2nd Sponsored tile cannot be dismissed individually, but it gets dismissed at the same time as the first Sponsored tile is dismissed.
• Here is a screen recording of the issue.

Comment 1

[Nan Jiang [:nanj]]

Attachment: Bug 1823949 - Fix an edge case for adding custom topsites r=thecount

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1822604

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f60624b10d53
Fix an edge case for adding custom topsites r=thecount

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f60624b10d53

Comment 5

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 113.0a1 (Build ID: 20230323094537), on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• New shortcuts can be added correctly and I can confirm that they also persist at browser restarts.

Comment 6

[Carmen Fat [:cfat] - Ecosystem QA]

Given that this issue was regressed by Bug 1822604 which was recently uplifted to Beta 112.0b6, this bug is now also reproducible on the 112 version. Updating the version flags accordingly.

Comment 7

[Nan Jiang [:nanj]]

[Tracking Requested - why for this release]: This bugfix is required for the 3rd sponsored tile experiment in Firefox 102.

Comment 8

[Nan Jiang [:nanj]]

Comment on attachment 9324472 [details]
Bug 1823949 - Fix an edge case for adding custom topsites r=thecount

Beta/Release Uplift Approval Request

• User impact if declined: The experiment user group will not be able to add custom shortcuts under certain conditions.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch would only apply to some experiment users, we can turn off the experiment through Nimbus if needed.
• String changes made/needed: None
• Is Android affected?: No

Comment 9

[Nan Jiang [:nanj]]

Hi Dianna, I'm sorry to bother you at this time. Wonder if we can get this uplifted to beta 112 given that today is the last day for the early beta cycle. Thanks in advance!

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9324472 [details]
Bug 1823949 - Fix an edge case for adding custom topsites r=thecount

Approved for 112.0b7

Comment 11

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d4391261af20

Comment 12

[Nan Jiang [:nanj]]

Thanks so much, Dianna!

Comment 13

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Beta 112.0b7 (Build ID: 20230326180212), on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• New shortcuts can be added correctly and I can confirm that they also persist at browser restarts.