Closed Bug 1824055 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 39154 - CSSTransitionDiscrete: Fix CounterRulesEqual

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Product:
Core
Component:
Layout: Generated Content, Lists, and Counters
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox114 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39154 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39154
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

CSSTransitionDiscrete: Fix CounterRulesEqual

Instead of returning the value of base::ranges::equal, the initial
implementation I merged of CounterRulesEqual was throwing away the
return value and unconditionally returning true.

Bug: 1399631, 1413556
Change-Id: I2df45579ddf02056ff48763772d55be7885460fd

Reviewed-on: https://chromium-review.googlesource.com/4363281
WPT-Export-Revision: b8af8d505d8446cbeaec0bf8319f4c8e8b5fe2ac

PR 39154 applied with additional changes from upstream: 98afc8a86461237414d32da9e6628499c0a0022a
Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 186 subtests

Status Summary

Firefox

OK : 1
PASS: 150[GitHub] 168[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt]
FAIL: 18

Chrome

OK : 1
PASS: 150
FAIL: 18

Safari

OK : 1
PASS: 125
FAIL: 43

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-lists/css-lists-no-interpolation.html [wpt.fyi]
    • CSS Transitions: property <counter-increment> from [initial] to [add 123] at (-0.3) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <counter-increment> from [initial] to [add 123] at (0) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <counter-increment> from [initial] to [add 123] at (0.3) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <counter-increment> from [add 5] to [add 123] at (-0.3) should be [add 5]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <counter-increment> from [add 5] to [add 123] at (0) should be [add 5]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <counter-increment> from [add 5] to [add 123] at (0.3) should be [add 5]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <counter-reset> from [initial] to [add 123] at (-0.3) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <counter-reset> from [initial] to [add 123] at (0) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <counter-reset> from [initial] to [add 123] at (0.3) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <counter-set> from [initial] to [add 123] at (-0.3) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <counter-set> from [initial] to [add 123] at (0) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <counter-set> from [initial] to [add 123] at (0.3) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <list-style-position> from [initial] to [inside] at (-0.3) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <list-style-position> from [initial] to [inside] at (0) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <list-style-position> from [initial] to [inside] at (0.3) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <list-style-type> from [initial] to [square] at (-0.3) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <list-style-type> from [initial] to [square] at (0) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <list-style-type> from [initial] to [square] at (0.3) should be [initial]: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a1ada8f51b45 [wpt PR 39154] - CSSTransitionDiscrete: Fix CounterRulesEqual, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a1ada8f51b45

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox114: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.