1824078 - Display parent folders in favourites

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Markus]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/112.0

Steps to reproduce:

I have different sub folders that are named the same, like this:

• Parent A
  • XXX
  • YYY
• Parent B
  • XXX
  • YYY

Actual results:

When I make both "XXX" folders a favourite, it shows like this in favourites:

• XXX
• XXX

Now I don't know the parent folder, which is an important information in this case.

Expected results:

Thunderbird <111 automatically displayed all parent folders like this in favourites, which I'd prefer:

• Parent A
  • XXX
• Parent B
  • XXX

Comment 2

[Markus]

https://bugzilla.mozilla.org/show_bug.cgi?id=1822523 is resolved (cannot comment there, though) but I still have the issue on 113.0b1. Is this something different?

Comment 3

[Markus]

Attachment: Favorites without parent folder

Favorites still don't display any parent folder on 113.0b3 so it looks like this if you have favorites with the same name but different parent.

Comment 4

[Magnus Melin [:mkmelin]]

Yeah this isn't quite right yet.

Comment 5

[Thomas D. (:thomas8)]

(In reply to Markus from comment #3)

Created attachment 9330106 [details]
Favorites without parent folder
Favorites still don't display any parent folder on 113.0b3 so it looks like this if you have favorites with the same name but different parent.

Markus, how does 102 handle this situation?

Comment 6

[Markus]

Markus, how does 102 handle this situation?

If I remember correctly it displays all parent folders of favorites and basically looks same like "All folders" view – just with fewer folders (only the favorites + their parents if any). The folder hierarchy in favortites view for the displayed folders is the same like in "All folders".

So e.g. if I have this in all folders ...

• Project A
  • Errors
    • Low prio
    • Standard (<-- Favorite folder)
    • Urgent (<-- Favorite folder)
• Project B
  • Errors
    • Low prio
    • Standard
    • Urgent (<-- Favorite folder)
• Project C
  • Errors
    • ... (no favorites here)

... it showed like this in favorites:

• Project A
  • Errors
    • Standard
    • Urgent
• Project B
  • Errors
    • Urgent

Comment 7

[Alessandro Castellani [:aleca]]

NI myself as we have some potential solutions for this that need to be explored

Comment 8

[Magnus Melin [:mkmelin]]

102 did a reasonable thing and displayed the parent as well when you favorited a child.
On a related note it's highly annoying that the actual favorite folders themselves do not show that they have expandable children :/

Comment 9

[Geoff Lankow (:darktrojan)]

I'll add the missing ancestors like we've got them in the Unread Folders mode.

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1824078 - Display ancestors of folders in Favourite Folders mode. r=aleca

This is basically sharing the code from the Unread Folders mode.

Depends on D178489

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fe8965e134e8
Display ancestors of folders in Favourite Folders mode. r=aleca

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9334915 [details]
Bug 1824078 - Display ancestors of folders in Favourite Folders mode. r=aleca

[Triage Comment]
Approved for beta

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 114.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/f6fbe3e22061