Closed
Bug 1824081
Opened 3 years ago
Closed 3 years ago
build-decision makes http requests without a timeout
Categories
(Release Engineering :: Firefox-CI Administration, defect)
Release Engineering
Firefox-CI Administration
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jcristau, Assigned: jcristau)
References
Details
Attachments
(2 files)
While investigating bug 1823120 and bug 1821513 I'm looking for any tasks that make http requests without setting a timeout, and build-decision came up since it's involved in 1823120.
Per https://requests.readthedocs.io/en/latest/user/quickstart/#timeouts:
Nearly all production code should use this parameter in nearly all requests. Failure to do so can cause your program to hang indefinitely
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → jcristau
Status: NEW → ASSIGNED
Pushed by jcristau@mozilla.com:
https://hg.mozilla.org/ci/ci-configuration/rev/92c07265a68b
set a timeout for http requests made by build-decision. r=releng-reviewers,gbrown,gabriel
|
|
Assignee | |
Comment 3•3 years ago
|
||
Pushed by jcristau@mozilla.com:
https://hg.mozilla.org/ci/ci-configuration/rev/ce4ae405f6c4
update build-decision docker image. r=releng-reviewers,bhearsum
|
|
Assignee | |
Updated•3 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•